From: Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
To: Alexander Graf <agraf-l3A5Bk7waGM@public.gmane.org>
Cc: kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Avi Kivity <avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
kvm-ppc <kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Hollis Blanchard
<hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Kevin Wolf <kwolf-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
bphilips-l3A5Bk7waGM@public.gmane.org,
Marcelo Tosatti
<mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 17/27] Make head_64.S aware of KVM real mode code
Date: Thu, 29 Oct 2009 13:45:06 +1100 [thread overview]
Message-ID: <1256784306.26770.18.camel@pasglop> (raw)
In-Reply-To: <1256137413-15256-18-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
On Wed, 2009-10-21 at 17:03 +0200, Alexander Graf wrote:
> We need to run some KVM trampoline code in real mode. Unfortunately, real mode
> only covers 8MB on Cell so we need to squeeze ourselves as low as possible.
>
> Also, we need to trap interrupts to get us back from guest state to host state
> without telling Linux about it.
>
> This patch adds interrupt traps and includes the KVM code that requires real
> mode in the real mode parts of Linux.
>
> Signed-off-by: Alexander Graf <agraf-l3A5Bk7waGM@public.gmane.org>
Acked-by: Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
> ---
> arch/powerpc/include/asm/exception-64s.h | 2 ++
> arch/powerpc/kernel/exceptions-64s.S | 8 ++++++++
> arch/powerpc/kernel/head_64.S | 7 +++++++
> 3 files changed, 17 insertions(+), 0 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/exception-64s.h b/arch/powerpc/include/asm/exception-64s.h
> index a98653b..57c4000 100644
> --- a/arch/powerpc/include/asm/exception-64s.h
> +++ b/arch/powerpc/include/asm/exception-64s.h
> @@ -147,6 +147,7 @@
> .globl label##_pSeries; \
> label##_pSeries: \
> HMT_MEDIUM; \
> + DO_KVM n; \
> mtspr SPRN_SPRG_SCRATCH0,r13; /* save r13 */ \
> EXCEPTION_PROLOG_PSERIES(PACA_EXGEN, label##_common)
>
> @@ -170,6 +171,7 @@ label##_pSeries: \
> .globl label##_pSeries; \
> label##_pSeries: \
> HMT_MEDIUM; \
> + DO_KVM n; \
> mtspr SPRN_SPRG_SCRATCH0,r13; /* save r13 */ \
> mfspr r13,SPRN_SPRG_PACA; /* get paca address into r13 */ \
> std r9,PACA_EXGEN+EX_R9(r13); /* save r9, r10 */ \
> diff --git a/arch/powerpc/kernel/exceptions-64s.S b/arch/powerpc/kernel/exceptions-64s.S
> index 1808876..fc3ead0 100644
> --- a/arch/powerpc/kernel/exceptions-64s.S
> +++ b/arch/powerpc/kernel/exceptions-64s.S
> @@ -41,6 +41,7 @@ __start_interrupts:
> . = 0x200
> _machine_check_pSeries:
> HMT_MEDIUM
> + DO_KVM 0x200
> mtspr SPRN_SPRG_SCRATCH0,r13 /* save r13 */
> EXCEPTION_PROLOG_PSERIES(PACA_EXMC, machine_check_common)
>
> @@ -48,6 +49,7 @@ _machine_check_pSeries:
> .globl data_access_pSeries
> data_access_pSeries:
> HMT_MEDIUM
> + DO_KVM 0x300
> mtspr SPRN_SPRG_SCRATCH0,r13
> BEGIN_FTR_SECTION
> mfspr r13,SPRN_SPRG_PACA
> @@ -77,6 +79,7 @@ ALT_FTR_SECTION_END_IFCLR(CPU_FTR_SLB)
> .globl data_access_slb_pSeries
> data_access_slb_pSeries:
> HMT_MEDIUM
> + DO_KVM 0x380
> mtspr SPRN_SPRG_SCRATCH0,r13
> mfspr r13,SPRN_SPRG_PACA /* get paca address into r13 */
> std r3,PACA_EXSLB+EX_R3(r13)
> @@ -115,6 +118,7 @@ data_access_slb_pSeries:
> .globl instruction_access_slb_pSeries
> instruction_access_slb_pSeries:
> HMT_MEDIUM
> + DO_KVM 0x480
> mtspr SPRN_SPRG_SCRATCH0,r13
> mfspr r13,SPRN_SPRG_PACA /* get paca address into r13 */
> std r3,PACA_EXSLB+EX_R3(r13)
> @@ -154,6 +158,7 @@ instruction_access_slb_pSeries:
> .globl system_call_pSeries
> system_call_pSeries:
> HMT_MEDIUM
> + DO_KVM 0xc00
> BEGIN_FTR_SECTION
> cmpdi r0,0x1ebe
> beq- 1f
> @@ -186,12 +191,15 @@ END_FTR_SECTION_IFSET(CPU_FTR_REAL_LE)
> * trickery is thus necessary
> */
> . = 0xf00
> + DO_KVM 0xf00
> b performance_monitor_pSeries
>
> . = 0xf20
> + DO_KVM 0xf20
> b altivec_unavailable_pSeries
>
> . = 0xf40
> + DO_KVM 0xf40
> b vsx_unavailable_pSeries
>
> #ifdef CONFIG_CBE_RAS
> diff --git a/arch/powerpc/kernel/head_64.S b/arch/powerpc/kernel/head_64.S
> index c38afdb..9258074 100644
> --- a/arch/powerpc/kernel/head_64.S
> +++ b/arch/powerpc/kernel/head_64.S
> @@ -37,6 +37,7 @@
> #include <asm/firmware.h>
> #include <asm/page_64.h>
> #include <asm/irqflags.h>
> +#include <asm/kvm_book3s_64_asm.h>
>
> /* The physical memory is layed out such that the secondary processor
> * spin code sits at 0x0000...0x00ff. On server, the vectors follow
> @@ -165,6 +166,12 @@ exception_marker:
> #include "exceptions-64s.S"
> #endif
>
> +/* KVM trampoline code needs to be close to the interrupt handlers */
> +
> +#ifdef CONFIG_KVM_BOOK3S_64_HANDLER
> +#include "../kvm/book3s_64_rmhandlers.S"
> +#endif
> +
> _GLOBAL(generic_secondary_thread_init)
> mr r24,r3
>
next prev parent reply other threads:[~2009-10-29 2:45 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-21 15:03 [PATCH 00/27] Add KVM support for Book3s_64 (PPC64) hosts v5 Alexander Graf
2009-10-21 15:03 ` [PATCH 01/27] Move dirty logging code to sub-arch Alexander Graf
[not found] ` <1256137413-15256-2-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2009-10-21 15:03 ` [PATCH 02/27] Pass PVR in sregs Alexander Graf
2009-10-21 15:03 ` [PATCH 03/27] Add Book3s definitions Alexander Graf
2009-10-21 15:03 ` [PATCH 04/27] Add Book3s fields to vcpu structs Alexander Graf
2009-10-21 15:03 ` [PATCH 05/27] Add asm/kvm_book3s.h Alexander Graf
2009-10-21 15:03 ` [PATCH 06/27] Add Book3s_64 intercept helpers Alexander Graf
2009-10-21 15:03 ` [PATCH 07/27] Add book3s_64 highmem asm code Alexander Graf
[not found] ` <1256137413-15256-8-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2009-10-21 15:03 ` [PATCH 08/27] Add SLB switching code for entry/exit Alexander Graf
[not found] ` <1256137413-15256-9-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2009-10-21 15:03 ` [PATCH 09/27] Add interrupt handling code Alexander Graf
[not found] ` <1256137413-15256-10-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2009-10-21 15:03 ` [PATCH 10/27] Add book3s.c Alexander Graf
2009-10-21 15:03 ` [PATCH 11/27] Add book3s_64 Host MMU handling Alexander Graf
2009-10-21 15:03 ` [PATCH 12/27] Add book3s_64 guest MMU Alexander Graf
[not found] ` <1256137413-15256-13-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2009-10-21 15:03 ` [PATCH 13/27] Add book3s_32 " Alexander Graf
[not found] ` <1256137413-15256-14-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2009-10-21 15:03 ` [PATCH 14/27] Add book3s_64 specific opcode emulation Alexander Graf
[not found] ` <1256137413-15256-15-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2009-10-21 15:03 ` [PATCH 15/27] Add mfdec emulation Alexander Graf
[not found] ` <1256137413-15256-16-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2009-10-21 15:03 ` [PATCH 16/27] Add desktop PowerPC specific emulation Alexander Graf
[not found] ` <1256137413-15256-17-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2009-10-21 15:03 ` [PATCH 17/27] Make head_64.S aware of KVM real mode code Alexander Graf
2009-10-21 15:03 ` [PATCH 18/27] Add Book3s_64 offsets to asm-offsets.c Alexander Graf
[not found] ` <1256137413-15256-19-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2009-10-21 15:03 ` [PATCH 19/27] Export symbols for KVM module Alexander Graf
[not found] ` <1256137413-15256-20-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2009-10-21 15:03 ` [PATCH 20/27] Split init_new_context and destroy_context Alexander Graf
[not found] ` <1256137413-15256-21-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2009-10-21 15:03 ` [PATCH 21/27] Export KVM symbols for module Alexander Graf
2009-10-21 15:03 ` [PATCH 22/27] Add fields to PACA Alexander Graf
[not found] ` <1256137413-15256-23-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2009-10-21 15:03 ` [PATCH 23/27] Export new PACA constants in asm-offsets Alexander Graf
2009-10-21 15:03 ` [PATCH 24/27] Include Book3s_64 target in buildsystem Alexander Graf
[not found] ` <1256137413-15256-25-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2009-10-21 15:03 ` [PATCH 25/27] Fix trace.h Alexander Graf
2009-10-21 15:03 ` [PATCH 26/27] Use Little Endian for Dirty Bitmap Alexander Graf
[not found] ` <1256137413-15256-27-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2009-10-21 15:03 ` [PATCH 27/27] Use hrtimers for the decrementer Alexander Graf
[not found] ` <1256137413-15256-24-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2009-10-29 2:50 ` [PATCH 23/27] Export new PACA constants in asm-offsets Benjamin Herrenschmidt
2009-10-29 2:50 ` [PATCH 22/27] Add fields to PACA Benjamin Herrenschmidt
2009-10-29 2:48 ` [PATCH 20/27] Split init_new_context and destroy_context Benjamin Herrenschmidt
2009-10-29 2:46 ` [PATCH 19/27] Export symbols for KVM module Benjamin Herrenschmidt
2009-10-29 2:53 ` Alexander Graf
2009-10-29 2:45 ` [PATCH 18/27] Add Book3s_64 offsets to asm-offsets.c Benjamin Herrenschmidt
[not found] ` <1256137413-15256-18-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2009-10-29 2:45 ` Benjamin Herrenschmidt [this message]
2009-10-21 15:22 ` [PATCH 00/27] Add KVM support for Book3s_64 (PPC64) hosts v5 Alexander Graf
[not found] ` <1256137413-15256-1-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2009-10-22 13:26 ` Arnd Bergmann
2009-10-23 0:33 ` Hollis Blanchard
[not found] ` <1256258028.7495.34.camel-6XWu2dSDoRTcKpUcGLbliUEOCMrvLtNR@public.gmane.org>
2009-10-25 13:01 ` Avi Kivity
[not found] ` <4AE44C14.8040507-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-10-26 21:18 ` Hollis Blanchard
2009-10-29 2:55 ` Benjamin Herrenschmidt
2009-10-26 23:06 ` Olof Johansson
[not found] ` <20091026230632.GB5366-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
2009-10-26 23:20 ` Hollis Blanchard
2009-10-26 23:21 ` Olof Johansson
2009-10-27 8:56 ` Avi Kivity
2009-10-27 13:42 ` Alexander Graf
[not found] ` <8E92E3B9-39D5-4D71-8B8E-96B49430B67B-l3A5Bk7waGM@public.gmane.org>
2009-10-27 15:49 ` Avi Kivity
-- strict thread matches above, loose matches on Subject: below --
2009-10-30 15:47 [PATCH 00/27] Add KVM support for Book3s_64 (PPC64) hosts v6 Alexander Graf
2009-10-30 15:47 ` [PATCH 17/27] Make head_64.S aware of KVM real mode code Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1256784306.26770.18.camel@pasglop \
--to=benh-xvmvhmargas8u2djnn8i7kb+6bgklq7r@public.gmane.org \
--cc=agraf-l3A5Bk7waGM@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=bphilips-l3A5Bk7waGM@public.gmane.org \
--cc=hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kwolf-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox