From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark McLoughlin Subject: Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network Date: Thu, 29 Oct 2009 15:01:18 +0000 Message-ID: <1256828478.10825.79.camel@blaa> References: <1256807803.10825.39.camel@blaa> <1256815818-sup-7805@xpc65.scottt> <1256818566.10825.58.camel@blaa> <4AE9A299.5060003@codemonkey.ws> <1256826351.10825.69.camel@blaa> <4AE9A90F.1060108@codemonkey.ws> <1256827719.10825.75.camel@blaa> <1256828478.25064.126.camel@x200> Reply-To: Mark McLoughlin Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Anthony Liguori , Scott Tsai , qemu-devel , kvm , Rusty Russell To: kirkland@canonical.com Return-path: Received: from mx1.redhat.com ([209.132.183.28]:65510 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754347AbZJ2PD1 (ORCPT ); Thu, 29 Oct 2009 11:03:27 -0400 In-Reply-To: <1256828478.25064.126.camel@x200> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, 2009-10-29 at 10:01 -0500, Dustin Kirkland wrote: > On Thu, 2009-10-29 at 14:48 +0000, Mark McLoughlin wrote: > > Ah, it all makes sense now. > >=20 > > I was getting confused between HOST_* and GUEST_* > >=20 > > this should have been: > >=20 > > features |=3D (1 << VIRTIO_NET_F_MAC); > > features |=3D (1 << VIRTIO_NET_F_HOST_CSUM); > > features |=3D (1 << VIRTIO_NET_F_HOST_TSO4); > > features |=3D (1 << VIRTIO_NET_F_HOST_TSO6); > > features |=3D (1 << VIRTIO_NET_F_HOST_ECN); > >=20 > > Could you try that Dustin? >=20 > Hmm, not sure I'm doing this correctly... I tried changing the > following, but looks like I might also have to define these as well, > since: >=20 > /tmp/qemu-kvm/qemu-kvm/hw/virtio-net.c:167: error: > =E2=80=98VIRTIO_NET_F_HOST_CSUM=E2=80=99 undeclared (first use in thi= s function) Sorry, should be VIRTIO_NET_F_CSUM ... the rest is correct Thanks, mark.