From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dustin Kirkland Subject: Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network Date: Thu, 29 Oct 2009 10:01:18 -0500 Message-ID: <1256828478.25064.126.camel@x200> References: <1256807803.10825.39.camel@blaa> <1256815818-sup-7805@xpc65.scottt> <1256818566.10825.58.camel@blaa> <4AE9A299.5060003@codemonkey.ws> <1256826351.10825.69.camel@blaa> <4AE9A90F.1060108@codemonkey.ws> <1256827719.10825.75.camel@blaa> Reply-To: kirkland@canonical.com Mime-Version: 1.0 Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-io+1EdYxHc3aVSkJ4w2E" Cc: Anthony Liguori , Scott Tsai , qemu-devel , kvm , Rusty Russell To: Mark McLoughlin Return-path: Received: from adelie.canonical.com ([91.189.90.139]:36216 "EHLO adelie.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753573AbZJ2PBW (ORCPT ); Thu, 29 Oct 2009 11:01:22 -0400 In-Reply-To: <1256827719.10825.75.camel@blaa> Sender: kvm-owner@vger.kernel.org List-ID: --=-io+1EdYxHc3aVSkJ4w2E Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2009-10-29 at 14:48 +0000, Mark McLoughlin wrote: > Ah, it all makes sense now. >=20 > I was getting confused between HOST_* and GUEST_* >=20 > this should have been: >=20 > features |=3D (1 << VIRTIO_NET_F_MAC); > features |=3D (1 << VIRTIO_NET_F_HOST_CSUM); > features |=3D (1 << VIRTIO_NET_F_HOST_TSO4); > features |=3D (1 << VIRTIO_NET_F_HOST_TSO6); > features |=3D (1 << VIRTIO_NET_F_HOST_ECN); >=20 > Could you try that Dustin? Hmm, not sure I'm doing this correctly... I tried changing the following, but looks like I might also have to define these as well, since: /tmp/qemu-kvm/qemu-kvm/hw/virtio-net.c:167: error: =E2=80=98VIRTIO_NET_F_HOST_CSUM=E2=80=99 undeclared (first use in this func= tion) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index ce8e6cb..6582e69 100644 --- a/hw/virtio-net.c +++ b/hw/virtio-net.c @@ -164,10 +164,10 @@ static uint32_t virtio_net_bad_features(VirtIODevice = *vdev) /* Linux kernel 2.6.25. It understood MAC (as everyone must), * but also these: */ features |=3D (1 << VIRTIO_NET_F_MAC); - features |=3D (1 << VIRTIO_NET_F_GUEST_CSUM); - features |=3D (1 << VIRTIO_NET_F_GUEST_TSO4); - features |=3D (1 << VIRTIO_NET_F_GUEST_TSO6); - features |=3D (1 << VIRTIO_NET_F_GUEST_ECN); + features |=3D (1 << VIRTIO_NET_F_HOST_CSUM); + features |=3D (1 << VIRTIO_NET_F_HOST_TSO4); + features |=3D (1 << VIRTIO_NET_F_HOST_TSO6); + features |=3D (1 << VIRTIO_NET_F_HOST_ECN); =20 return features & virtio_net_get_features(vdev); } --=-io+1EdYxHc3aVSkJ4w2E Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEABECAAYFAkrprj4ACgkQs7pNXIOmEZToBACfcym/slRtyw0plW6+A0M88GtY 4MUAnA26Emqnn8lRIYeBBR+0kPmzEF3/ =BdC+ -----END PGP SIGNATURE----- --=-io+1EdYxHc3aVSkJ4w2E--