From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Meneghel Rodrigues Subject: Re: [Autotest] [PATCH] Move global configuration files to client dir Date: Wed, 11 Nov 2009 22:09:59 -0200 Message-ID: <1257984599.2789.1.camel@localhost.localdomain> References: <1257938642-6613-1-git-send-email-lmr@redhat.com> <394b34480911110732o17ad5a1di6bc5fb2c20d79192@mail.gmail.com> <1257959791.2789.0.camel@localhost.localdomain> <394b34480911110930l257440a1t151aac80270db4af@mail.gmail.com> <5029f4960911111559l504ef53dh3242ed58e54c7c2a@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: John Admanski , autotest@test.kernel.org, kvm@vger.kernel.org, Scott Zawalski To: Steve Howard Return-path: Received: from mx1.redhat.com ([209.132.183.28]:29186 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757535AbZKLAKE (ORCPT ); Wed, 11 Nov 2009 19:10:04 -0500 In-Reply-To: <5029f4960911111559l504ef53dh3242ed58e54c7c2a@mail.gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, 2009-11-11 at 15:59 -0800, Steve Howard wrote: > On Wed, Nov 11, 2009 at 9:30 AM, John Admanski wrote: > > I thought about it a bit more: > > > > Maybe a better approach would be to have the global_config module find > > the ini file in job.autodir (so on a client it would show up in the > > client/ dir, and on the server in the "true" top-level dir) and then > > add support to Autotest.run so that it copies over the server's copy > > of the config to the client before launching a client job? > > > > So that way it would "just work", and changes to the server config > > would automatically get pushed out to client jobs. All without moving > > the file that users running a server need to edit. And it's not too > > complex of a design; the Autotest.run code already needs to copy over > > a few files by hand like control files so copying over the config too > > isn't too much of a burden. > > For the record, I agree with John's proposed approach. Yes, I am preparing a patch using John's idea, will send it tomorrow morning. Thanks guys, > Steve