public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] Fix null DESTDIR in depmod execution
@ 2009-11-13  6:23 Sheng Yang
  2009-11-13 11:24 ` Jan Kiszka
  0 siblings, 1 reply; 2+ messages in thread
From: Sheng Yang @ 2009-11-13  6:23 UTC (permalink / raw)
  To: Jan Kiszka; +Cc: kvm, Sheng Yang

commit 52ea5897fa9fdadf0cc1a5242a23ce3dab599769 "Use DESTDIR consitently on
installation" add -b ${DESTDIR} to depmod. But the DESTDIR is default NULL,
then depmod would report error.

Set DESTDIR=/ as default

Signed-off-by: Sheng Yang <sheng@linux.intel.com>
---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index f406e3d..33ddc81 100644
--- a/Makefile
+++ b/Makefile
@@ -7,7 +7,7 @@ NONARCH_CONFIG = $(filter-out $(ARCH_CONFIG),X86 IA64)
 
 KVERREL = $(patsubst /lib/modules/%/build,%,$(KERNELDIR))
 
-DESTDIR=
+DESTDIR = /
 
 MAKEFILE_PRE = $(ARCH_DIR)/Makefile.pre
 
-- 
1.5.4.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] Fix null DESTDIR in depmod execution
  2009-11-13  6:23 [PATCH 1/1] Fix null DESTDIR in depmod execution Sheng Yang
@ 2009-11-13 11:24 ` Jan Kiszka
  0 siblings, 0 replies; 2+ messages in thread
From: Jan Kiszka @ 2009-11-13 11:24 UTC (permalink / raw)
  To: Sheng Yang; +Cc: kvm@vger.kernel.org

Sheng Yang wrote:
> commit 52ea5897fa9fdadf0cc1a5242a23ce3dab599769 "Use DESTDIR consitently on
> installation" add -b ${DESTDIR} to depmod. But the DESTDIR is default NULL,
> then depmod would report error.
> 
> Set DESTDIR=/ as default
> 
> Signed-off-by: Sheng Yang <sheng@linux.intel.com>
> ---
>  Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index f406e3d..33ddc81 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -7,7 +7,7 @@ NONARCH_CONFIG = $(filter-out $(ARCH_CONFIG),X86 IA64)
>  
>  KVERREL = $(patsubst /lib/modules/%/build,%,$(KERNELDIR))
>  
> -DESTDIR=
> +DESTDIR = /
>  
>  MAKEFILE_PRE = $(ARCH_DIR)/Makefile.pre
>  

Yeah, thanks, applied.

But please add a prefix to your patch subjects in the future to identify
the subsystem they applies to.

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-11-13 11:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-13  6:23 [PATCH 1/1] Fix null DESTDIR in depmod execution Sheng Yang
2009-11-13 11:24 ` Jan Kiszka

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox