From mboxrd@z Thu Jan  1 00:00:00 1970
From: Steven Rostedt <srostedt@redhat.com>
Subject: Re: kvmmmu tracing
Date: Mon, 23 Nov 2009 09:58:58 -0500
Message-ID: <1258988338.31359.147.camel@localhost.localdomain>
References: <1258974375.7094.158.camel@johannes.local>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: kvm <kvm@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Avi Kivity <avi@redhat.com>,
	Steven Rostedt <rostedt@goodmis.org>
To: Johannes Berg <johannes@sipsolutions.net>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:24348 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751186AbZKWO7S (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 23 Nov 2009 09:59:18 -0500
In-Reply-To: <1258974375.7094.158.camel@johannes.local>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, 2009-11-23 at 12:06 +0100, Johannes Berg wrote:
> Commit f691fe1da7e2715137d21ae5a80bec64db4625db is really broken wrt.
> the userspace interface for tracing because of the weird
> KVM_MMU_PAGE_PRINTK macro.
> 
> Maybe we should have a "unsafe for export" flag for events, if they do
> strange things like that?
> 
> As it stands, I can't use trace-cmd on an x86 machine that has kvm
> enabled because it will try to read all the kvm stuff. Arguably, it
> should only try to parse it when it needs it (i.e. not for me) but still
> it's very inconvenient to export something to userspace that it cannot
> possibly understand.

Note, I updated trace-cmd. I still does not read this macro nicely, but
it at least does not fail anymore.

-- Steve