Re: [PATCH v2 04/12] Add "handle page fault" PV helper.

Peter Zijlstra
2009-11-23T15:32:30Z

On Mon, 2009-11-23 at 16:05 +0200, Gleb Natapov wrote:

> diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c
> index f4cee90..14707dc 100644
> --- a/arch/x86/mm/fault.c
> +++ b/arch/x86/mm/fault.c
> @@ -952,6 +952,9 @@ do_page_fault(struct pt_regs *regs, unsigned long error_code)
> int write;
> int fault;
>
> + if (arch_handle_page_fault(regs, error_code))
> + return;
> +
> tsk = current;
> mm = tsk->mm;
>

That's a bit daft, the pagefault handler is already arch specific, so
you're placing an arch_ hook into arch code, that doesn't make sense.