From: Sheng Yang <sheng@linux.intel.com>
To: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org, Sheng Yang <sheng@linux.intel.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: [PATCH] qemu-kvm: Fix INTx assigned device can't work bug
Date: Tue, 24 Nov 2009 18:17:42 +0800 [thread overview]
Message-ID: <1259057862-28514-1-git-send-email-sheng@linux.intel.com> (raw)
Commit 6b5bbd04 "qdev-ify device assignment" forgot to put assigned devices
to "devs" list. So when IRQ routing changed in pci configure space, calling to
assigned_dev_update_irqs() won't update device guest IRQ, then assigned INTx
devices fail to work.
(OK, I am now aware of the fact that people don't use INTx these days...)
CC: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Sheng Yang <sheng@linux.intel.com>
---
hw/device-assignment.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/device-assignment.c b/hw/device-assignment.c
index 516cf14..64f3dc2 100644
--- a/hw/device-assignment.c
+++ b/hw/device-assignment.c
@@ -1180,6 +1180,7 @@ static int assigned_initfn(struct PCIDevice *pci_dev)
goto assigned_out;
assigned_dev_load_option_rom(dev);
+ QLIST_INSERT_HEAD(&devs, dev, next);
return 0;
assigned_out:
--
1.5.4.5
next reply other threads:[~2009-11-24 10:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-24 10:17 Sheng Yang [this message]
2009-11-25 13:00 ` [PATCH] qemu-kvm: Fix INTx assigned device can't work bug Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259057862-28514-1-git-send-email-sheng@linux.intel.com \
--to=sheng@linux.intel.com \
--cc=avi@redhat.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox