[PATCH] qemu-kvm: Fix INTx assigned device can't work bug

[PATCH] qemu-kvm: Fix INTx assigned device can't work bug

[Sheng Yang]

Commit 6b5bbd04 "qdev-ify device assignment" forgot to put assigned devices
to "devs" list. So when IRQ routing changed in pci configure space, calling to
assigned_dev_update_irqs() won't update device guest IRQ, then assigned INTx
devices fail to work.

(OK, I am now aware of the fact that people don't use INTx these days...)

CC: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Sheng Yang <sheng@linux.intel.com>
---
 hw/device-assignment.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/hw/device-assignment.c b/hw/device-assignment.c
index 516cf14..64f3dc2 100644
--- a/hw/device-assignment.c
+++ b/hw/device-assignment.c
@@ -1180,6 +1180,7 @@ static int assigned_initfn(struct PCIDevice *pci_dev)
             goto assigned_out;
 
     assigned_dev_load_option_rom(dev);
+    QLIST_INSERT_HEAD(&devs, dev, next);
     return 0;
 
 assigned_out:
-- 
1.5.4.5

Re: [PATCH] qemu-kvm: Fix INTx assigned device can't work bug

[Marcelo Tosatti]

On Tue, Nov 24, 2009 at 06:17:42PM +0800, Sheng Yang wrote:
> Commit 6b5bbd04 "qdev-ify device assignment" forgot to put assigned devices
> to "devs" list. So when IRQ routing changed in pci configure space, calling to
> assigned_dev_update_irqs() won't update device guest IRQ, then assigned INTx
> devices fail to work.
> 
> (OK, I am now aware of the fact that people don't use INTx these days...)

Applied, thanks.