From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sheng Yang Subject: [PATCH] qemu-kvm: Fix INTx assigned device can't work bug Date: Tue, 24 Nov 2009 18:17:42 +0800 Message-ID: <1259057862-28514-1-git-send-email-sheng@linux.intel.com> Cc: kvm@vger.kernel.org, Sheng Yang , Gerd Hoffmann To: Avi Kivity , Marcelo Tosatti Return-path: Received: from mga02.intel.com ([134.134.136.20]:43326 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932571AbZKXKSC (ORCPT ); Tue, 24 Nov 2009 05:18:02 -0500 Sender: kvm-owner@vger.kernel.org List-ID: Commit 6b5bbd04 "qdev-ify device assignment" forgot to put assigned devices to "devs" list. So when IRQ routing changed in pci configure space, calling to assigned_dev_update_irqs() won't update device guest IRQ, then assigned INTx devices fail to work. (OK, I am now aware of the fact that people don't use INTx these days...) CC: Gerd Hoffmann Signed-off-by: Sheng Yang --- hw/device-assignment.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/device-assignment.c b/hw/device-assignment.c index 516cf14..64f3dc2 100644 --- a/hw/device-assignment.c +++ b/hw/device-assignment.c @@ -1180,6 +1180,7 @@ static int assigned_initfn(struct PCIDevice *pci_dev) goto assigned_out; assigned_dev_load_option_rom(dev); + QLIST_INSERT_HEAD(&devs, dev, next); return 0; assigned_out: -- 1.5.4.5