From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [kvm-unit-tests PATCH v8 08/12] x86: Cleanup PAGE_* constants
Date: Wed, 8 Jun 2016 03:58:07 -0400 (EDT)
Message-ID: <1259165288.20762327.1465372687004.JavaMail.zimbra@redhat.com>
References: <cover.1465207665.git.agordeev@redhat.com> <67978bcc43b1e15d826583ce26b828ea4bdc6b7e.1465207665.git.agordeev@redhat.com> <d00a3576-b5e2-4c3f-535b-b6a9ac3b945b@redhat.com> <20160608075940.GC1565@agordeev.lab.eng.brq.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, Andrew Jones <drjones@redhat.com>,
	Thomas Huth <thuth@redhat.com>,
	Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
To: Alexander Gordeev <agordeev@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx3-phx2.redhat.com ([209.132.183.24]:57029 "EHLO
	mx3-phx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750756AbcFHH6J (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 8 Jun 2016 03:58:09 -0400
In-Reply-To: <20160608075940.GC1565@agordeev.lab.eng.brq.redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>


> We have page constants defined this way for every other arch:
> 
> lib/arm/asm/page.h
> lib/arm64/asm/page.h
> lib/asm-generic/page.h (covers ppc64)
> 
> Why not to bring x86 in line also?

The bug is in the others. :)  There's no reason for kvm-unit-tests to
depend on Linux, and PAGE_SIZE is never used in assembly either.

Paolo