Re: [PATCH] KVM test: tests_base.cfg updated with windows unattended install

[Lucas Meneghel Rodrigues <lmr@redhat.com>]

On Wed, 2010-01-20 at 08:33 -0500, Michael Goldish wrote:
> ----- "Lucas Meneghel Rodrigues" <lmr@redhat.com> wrote:
> 
> > Update the config file tests_base.cfg with the
> > recently added windows unattended install files
> > (r4109), so one is actually able to use them
> > on tests.
> > 
> > Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
> > ---
> >  client/tests/kvm/tests_base.cfg.sample |   40
> > +++++++++++++++++++++++++++++++-
> >  1 files changed, 39 insertions(+), 1 deletions(-)
> > 
> > diff --git a/client/tests/kvm/tests_base.cfg.sample
> > b/client/tests/kvm/tests_base.cfg.sample
> > index b8f25f4..a41a848 100644
> > --- a/client/tests/kvm/tests_base.cfg.sample
> > +++ b/client/tests/kvm/tests_base.cfg.sample
> > @@ -577,6 +577,9 @@ variants:
> >          cpu_chk_cmd = echo %NUMBER_OF_PROCESSORS%
> >          mem_chk_cmd = wmic memphysical
> >  
> > +        unattended_install:
> > +            timeout = 7200
> > +            finish_program = deps/finish.exe
> >          migrate:
> >              migration_test_command = ver && vol
> >              migration_bg_command = start ping -t localhost
> > @@ -648,7 +651,6 @@ variants:
> >                      md5sum = 743450644b1d9fe97b3cf379e22dceb0
> >                      md5sum_1m = b473bf75af2d1269fec8958cf0202bfd
> >                      unattended_file = unattended/winxp32.sif
> > -                    finish_program = deps/finish.exe
> >                  setup:
> >                      steps = WinXP-32-rss.steps
> >  
> > @@ -678,6 +680,11 @@ variants:
> >                              md5sum =
> > 03e921e9b4214773c21a39f5c3f42ef7
> >                              md5sum_1m =
> > 37c2fdec15ac4ec16aa10fdfdb338aa3
> >                              user = user
> > +                        unattended_install:
> > +                            cdrom = windows/Windows2003_r2_VLK.iso
> > +                            md5sum =
> > 03e921e9b4214773c21a39f5c3f42ef7
> > +                            md5sum_1m =
> > 37c2fdec15ac4ec16aa10fdfdb338aa3
> > +                            unattended_file =
> > unattended/win2003-32.sif
> >                          setup:
> >                              steps = Win2003-32-rss.steps
> 
> Some code can be saved by using the fact that install and
> unattended_install use the same ISOs:
> 
> install|unattended_install:
>     cdrom = windows/Windows2003_r2_VLK.iso
>     md5sum = 03e921e9b4214773c21a39f5c3f42ef7
>     md5sum_1m = 37c2fdec15ac4ec16aa10fdfdb338aa3
> install:
>     user = user
> unattended_install:
>     unattended_file = unattended/win2003-32.sif
> 
> It's not important, just an alternative to consider.

Good point, we should probably go over the config files upstream and do
all these small adjustments.