From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Meneghel Rodrigues Subject: Re: [Autotest PATCH] KVM-test: Add a subtest 'qemu_img' Date: Thu, 28 Jan 2010 11:14:44 -0200 Message-ID: <1264684484.2416.0.camel@localhost.localdomain> References: <1264476309-4867-1-git-send-email-yzhou@redhat.com> <1264525894.2316.89.camel@localhost.localdomain> <20100128093726.GB2356@aFu.nay.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: autotest@test.kernel.org, kvm@vger.kernel.org To: Yolkfull Chow Return-path: In-Reply-To: <20100128093726.GB2356@aFu.nay.redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: autotest-bounces@test.kernel.org Errors-To: autotest-bounces@test.kernel.org List-Id: kvm.vger.kernel.org On Thu, 2010-01-28 at 17:37 +0800, Yolkfull Chow wrote: > On Tue, Jan 26, 2010 at 03:11:34PM -0200, Lucas Meneghel Rodrigues wrote: > > That said, I was wondering if we could consolidate all qemu-img tests to > > a single execution, instead of splitting it to several variants. We > > could keep a failure record, execute all tests and fail the entire test > > if any of them failed. It's not like terribly important, but it seems > > more logical to group all qemu-img subcommands testing under a single > > test. > > Hi Lucas, > > After considering above suggestion about merging all qemu-img tests into single test, > I did decision that keep current method due to reason that: > 1) it's convenient to maintain so many parameters of each test variant. > 2) current method does not affect global results since even if one subtest of 'qemu-img' failes, > it will nor block following subtests (we can still get whole test results) > 3) it's possible for user to run single subtest of qemu-img, say only test 'rebase' subcommand > > As you also said this is not terribly important, let's keep it going. What's your opinion? Ok, I am fine with it! Lucas