From: Lucas Meneghel Rodrigues <lmr@redhat.com>
To: Michael Goldish <mgoldish@redhat.com>
Cc: kvm@vger.kernel.org, autotest@test.kernel.org
Subject: Re: [PATCH] KVM test: Ensure multiple pre/post commands can run
Date: Sun, 07 Feb 2010 23:11:51 -0200 [thread overview]
Message-ID: <1265591511.2409.1.camel@localhost.localdomain> (raw)
In-Reply-To: <1033600210.1156381265565571839.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
On Sun, 2010-02-07 at 12:59 -0500, Michael Goldish wrote:
> ----- "Lucas Meneghel Rodrigues" <lmr@redhat.com> wrote:
>
> > The way tests are currently defined, running unattended
> > install + hugepages will allways skip unattended install
> > setup step (coincidentally the tests on our test farm
> > were working because previous executions of the unattended
> > install script ran, leaving the environment prepared for
> > unattended install).
> >
> > So, make sure pre_commands on default tests.cfg file are
> > additive, and the preprocessor splits the pre_command
> > string, and executes pre/post commands in sequence.
> >
> > Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
>
> Why not just append ';' to each command?
>
> For example:
>
> pre_command = "scripts/unattended.py;"
> ...
> pre_command += " scripts/hugepage.py;"
>
> (the quotes can be omitted)
>
> IMO this is simpler.
Yes, agreed. Will revert the patch and fix this.
next prev parent reply other threads:[~2010-02-08 1:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1712820999.1156341265565305970.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
2010-02-07 17:59 ` [PATCH] KVM test: Ensure multiple pre/post commands can run Michael Goldish
2010-02-08 1:11 ` Lucas Meneghel Rodrigues [this message]
2010-02-09 12:58 ` [Autotest] " Lucas Meneghel Rodrigues
2010-02-05 11:16 Lucas Meneghel Rodrigues
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265591511.2409.1.camel@localhost.localdomain \
--to=lmr@redhat.com \
--cc=autotest@test.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=mgoldish@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox