From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lucas Meneghel Rodrigues <lmr@redhat.com>
Subject: Re: [PATCH] KVM test: Ensure multiple pre/post commands can run
Date: Sun, 07 Feb 2010 23:11:51 -0200
Message-ID: <1265591511.2409.1.camel@localhost.localdomain>
References: <1033600210.1156381265565571839.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, autotest@test.kernel.org
To: Michael Goldish <mgoldish@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:42550 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755127Ab0BHBLz (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 7 Feb 2010 20:11:55 -0500
In-Reply-To: <1033600210.1156381265565571839.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sun, 2010-02-07 at 12:59 -0500, Michael Goldish wrote:
> ----- "Lucas Meneghel Rodrigues" <lmr@redhat.com> wrote:
> 
> > The way tests are currently defined, running unattended
> > install + hugepages will allways skip unattended install
> > setup step (coincidentally the tests on our test farm
> > were working because previous executions of the unattended
> > install script ran, leaving the environment prepared for
> > unattended install).
> > 
> > So, make sure pre_commands on default tests.cfg file are
> > additive, and the preprocessor splits the pre_command
> > string, and executes pre/post commands in sequence.
> > 
> > Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
> 
> Why not just append ';' to each command?
> 
> For example:
> 
> pre_command = "scripts/unattended.py;"
> ...
> pre_command += " scripts/hugepage.py;"
> 
> (the quotes can be omitted)
> 
> IMO this is simpler.

Yes, agreed. Will revert the patch and fix this.