From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adam Litke Subject: Re: KVM in -next is somewhat busted Date: Mon, 08 Feb 2010 08:48:52 -0600 Message-ID: <1265640532.3457.17.camel@aglitke> References: <20100208142752.2e859b7d@lxorguk.ukuu.org.uk> <4B70229D.4080603@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Alan Cox , linux-kernel@vger.kernel.org, KVM list , Rusty Russell To: Avi Kivity Return-path: In-Reply-To: <4B70229D.4080603@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org This is probably fixed by this patch from Rusty... Strangely, I have not seen this on my test systems. When running under qemu-kvm-0.11.0: BUG: unable to handle kernel paging request at 56e58955 ... Process vballoon (pid: 1297, ti=c7976000 task=c70a6ca0 task.ti=c7 ... Call Trace: [] ? balloon+0x1b3/0x440 [virtio_balloon] [] ? schedule+0x327/0x9d0 [] ? balloon+0x0/0x440 [virtio_balloon] [] ? kthread+0x74/0x80 [] ? kthread+0x0/0x80 [] ? kernel_thread_helper+0x6/0x30 need_stats_update should be zero-initialized. Signed-off-by: Rusty Russell Cc: Adam Litke diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -292,6 +292,7 @@ static int virtballoon_probe(struct virt vb->num_pages = 0; init_waitqueue_head(&vb->config_change); vb->vdev = vdev; + vb->need_stats_update = 0; /* We expect two virtqueues: inflate and deflate, * and optionally stat. */ On Mon, 2010-02-08 at 16:41 +0200, Avi Kivity wrote: > (fixed kvm@ address) > > > On 02/08/2010 04:27 PM, Alan Cox wrote: > > Reliably at boot time with todays -next I get the following: > > > > BUG: unable to handle kernel paging request at 0000000000001028 > > IP: [] balloon+0x1a1/0x309 [virtio_balloon] > > PGD 2cd42067 PUD 3b9dc067 PMD 0 > > Oops: 0000 [#1] SMP > > last sysfs file: /sys/devices/virtio-pci/virtio4/block/vdd/removable > > CPU 3 > > Pid: 511, comm: vballoon Not tainted 2.6.33-rc7-next-20100208+ #51 / > > RIP: 0010:[] [] balloon+0x1a1/0x309 [virtio_balloon] > > > > Looks like the guest is broken, not the host. Do things work if you > leave out CONFIG_VIRTIO_BALLOON? > > Copying Adam Litke, who's name is on the latest balloon changes. > -- Thanks, Adam