Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Huang Ying <ying.huang@intel.com>
To: Avi Kivity <avi@redhat.com>,
	Anthony Liguori <anthony@codemonkey.ws>,
	Jan Kiszka <jan.kiszka@siemens.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: [PATCH -v2] Add savevm/loadvm support for MCE
Date: Tue, 02 Mar 2010 13:40:13 +0800	[thread overview]
Message-ID: <1267508413.1640.88.camel@yhuang-dev.sh.intel.com> (raw)

MCE registers are saved/load into/from CPUState in
kvm_arch_save/load_regs. To simulate the MCG_STATUS clearing upon
reset, MSR_MCG_STATUS is set to 0 for KVM_PUT_RESET_STATE.

v2:

 - Rebased on new CPU registers save/load framework.

Signed-off-by: Huang Ying <ying.huang@intel.com>
---
 qemu-kvm-x86.c |   43 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

--- a/qemu-kvm-x86.c
+++ b/qemu-kvm-x86.c
@@ -979,11 +979,33 @@ void kvm_arch_load_regs(CPUState *env, i
         set_msr_entry(&msrs[n++], MSR_KVM_SYSTEM_TIME, env->system_time_msr);
         set_msr_entry(&msrs[n++], MSR_KVM_WALL_CLOCK, env->wall_clock_msr);
     }
+#ifdef KVM_CAP_MCE
+    if (env->mcg_cap && level == KVM_PUT_RESET_STATE) {
+        /*
+         * MCG_STATUS should reset to 0 after reset, while other MCE
+         * registers should be unchanged
+         */
+        set_msr_entry(&msrs[n++], MSR_MCG_STATUS, 0);
+    }
+#endif
 
     rc = kvm_set_msrs(env, msrs, n);
     if (rc == -1)
         perror("kvm_set_msrs FAILED");
 
+#ifdef KVM_CAP_MCE
+    if (env->mcg_cap && level == KVM_PUT_FULL_STATE) {
+        n = 0;
+        set_msr_entry(&msrs[n++], MSR_MCG_STATUS, env->mcg_status);
+        set_msr_entry(&msrs[n++], MSR_MCG_CTL, env->mcg_ctl);
+        for (i = 0; i < (env->mcg_cap & 0xff); i++)
+            set_msr_entry(&msrs[n++], MSR_MC0_CTL + i, env->mce_banks[i]);
+        rc = kvm_set_msrs(env, msrs, n);
+        if (rc == -1)
+            perror("kvm_set_msrs FAILED");
+    }
+#endif
+
     if (level >= KVM_PUT_RESET_STATE) {
         kvm_arch_load_mpstate(env);
         kvm_load_lapic(env);
@@ -1155,6 +1177,27 @@ void kvm_arch_save_regs(CPUState *env)
                 return;
         }
     }
+
+#ifdef KVM_CAP_MCE
+    if (env->mcg_cap) {
+        msrs[0].index = MSR_MCG_STATUS;
+        msrs[1].index = MSR_MCG_CTL;
+        n = (env->mcg_cap & 0xff) * 4;
+        for (i = 0; i < n; i++)
+            msrs[2 + i].index = MSR_MC0_CTL + i;
+
+        rc = kvm_get_msrs(env, msrs, n + 2);
+        if (rc == -1)
+            perror("kvm_get_msrs FAILED");
+        else {
+            env->mcg_status = msrs[0].data;
+            env->mcg_ctl = msrs[1].data;
+            for (i = 0; i < n; i++)
+                env->mce_banks[i] = msrs[2 + i].data;
+        }
+    }
+#endif
+
     kvm_arch_save_mpstate(env);
     kvm_save_lapic(env);
     kvm_get_vcpu_events(env);



             reply	other threads:[~2010-03-02  5:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-02  5:40 Huang Ying [this message]
2010-03-02  8:09 ` [PATCH -v2] Add savevm/loadvm support for MCE Jan Kiszka
2010-03-02  8:36   ` Huang Ying
2010-03-02 10:20     ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1267508413.1640.88.camel@yhuang-dev.sh.intel.com \
    --to=ying.huang@intel.com \
    --cc=andi@firstfloor.org \
    --cc=anthony@codemonkey.ws \
    --cc=avi@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox