From: Lucas Meneghel Rodrigues <lmr@redhat.com>
To: Yolkfull Chow <yzhou@redhat.com>
Cc: autotest@test.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM test: Put os.kill in kvm_stat into try block to avoid traceback
Date: Mon, 29 Mar 2010 11:04:03 -0300 [thread overview]
Message-ID: <1269871443.2585.0.camel@localhost.localdomain> (raw)
In-Reply-To: <1269856603-8405-1-git-send-email-yzhou@redhat.com>
On Mon, 2010-03-29 at 17:56 +0800, Yolkfull Chow wrote:
> Sometimes it tried to kill an already terminated process which can cause
> a traceback. This patch fixes the problem.
Thanks, applied!
> Signed-off-by: Yolkfull Chow <yzhou@redhat.com>
> ---
> client/profilers/kvm_stat/kvm_stat.py | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/client/profilers/kvm_stat/kvm_stat.py b/client/profilers/kvm_stat/kvm_stat.py
> index 7568a03..59d6ff6 100644
> --- a/client/profilers/kvm_stat/kvm_stat.py
> +++ b/client/profilers/kvm_stat/kvm_stat.py
> @@ -51,7 +51,10 @@ class kvm_stat(profiler.profiler):
>
> @param test: Autotest test on which this profiler will operate on.
> """
> - os.kill(self.pid, 15)
> + try:
> + os.kill(self.pid, 15)
> + except OSError:
> + pass
>
>
> def report(self, test):
prev parent reply other threads:[~2010-03-29 14:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 9:56 [PATCH] KVM test: Put os.kill in kvm_stat into try block to avoid traceback Yolkfull Chow
2010-03-29 14:04 ` Lucas Meneghel Rodrigues [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269871443.2585.0.camel@localhost.localdomain \
--to=lmr@redhat.com \
--cc=autotest@test.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=yzhou@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox