From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Meneghel Rodrigues Subject: Re: [PATCH 9/9] KVM test: Redirect the console to serial for all linux guests Date: Thu, 06 May 2010 12:43:50 -0300 Message-ID: <1273160630.15652.27.camel@freedom> References: <20100426095656.26268.50549.stgit@localhost.localdomain> <20100426100434.26268.52519.stgit@localhost.localdomain> <4BD828F8.2080609@redhat.com> <4BE232C5.9010808@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: autotest@test.kernel.org, KVM@test.kernel.org, mailing list To: Jason Wang Return-path: In-Reply-To: <4BE232C5.9010808@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: autotest-bounces@test.kernel.org Errors-To: autotest-bounces@test.kernel.org List-Id: kvm.vger.kernel.org On Thu, 2010-05-06 at 11:08 +0800, Jason Wang wrote: > Michael Goldish wrote: > > On 04/26/2010 01:04 PM, Jason Wang wrote: > > > >> As we have the ability to dump the content from serial console or use > >> a session through it, we need to redirect the console to serial > >> through unattended files to make use of it. > >> > >> Signed-off-by: Jason Wang > >> --- > >> client/tests/kvm/unattended/Fedora-10.ks | 2 +- > >> client/tests/kvm/unattended/Fedora-11.ks | 2 +- > >> client/tests/kvm/unattended/Fedora-12.ks | 2 +- > >> client/tests/kvm/unattended/Fedora-8.ks | 2 +- > >> client/tests/kvm/unattended/Fedora-9.ks | 2 +- > >> client/tests/kvm/unattended/OpenSUSE-11.xml | 1 + > >> client/tests/kvm/unattended/RHEL-3-series.ks | 2 +- > >> client/tests/kvm/unattended/RHEL-4-series.ks | 2 +- > >> client/tests/kvm/unattended/RHEL-5-series.ks | 2 +- > >> client/tests/kvm/unattended/SLES-11.xml | 1 + > >> 10 files changed, 10 insertions(+), 8 deletions(-) > >> > >> diff --git a/client/tests/kvm/unattended/Fedora-10.ks b/client/tests/kvm/unattended/Fedora-10.ks > >> index 61e59d7..8628036 100644 > >> --- a/client/tests/kvm/unattended/Fedora-10.ks > >> +++ b/client/tests/kvm/unattended/Fedora-10.ks > >> @@ -11,7 +11,7 @@ firewall --enabled --ssh > >> selinux --enforcing > >> timezone --utc America/New_York > >> firstboot --disable > >> -bootloader --location=mbr > >> +bootloader --location=mbr --append="console=ttyS0,115200" > >> > > > > I see no reason to completely silence the regular console. We can let > > some output go to the regular console as well as the serial one by using > > > > --append="console=tty0 console=ttyS0" > > > > > Yes, we should always keep the tty0. Thanks for pointing that. It seems like we are opening possibilities on windows land - it seems that there is an administration console running on windows' serial ports by default: http://technet.microsoft.com/en-us/library/cc785873%28WS.10%29.aspx Need to check that out. Excellent. Jason, the patchset looks mostly good, please implement the suggestions pointed out on the comments and re-send it.