From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] pci: cleanly backout of pci_qdev_init()
Date: Tue, 11 May 2010 12:40:52 -0600
Message-ID: <1273603252.2682.50.camel@localhost>
References: <20100510150016.15398.36521.stgit@virtlab9.virt.bos.redhat.com>
	 <AANLkTimIxCqy7lau-nd8VLfoFjXXFNtf1p7Oem4HjVyS@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
To: Blue Swirl <blauwirbel@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:64880 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754459Ab0EKSk5 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 11 May 2010 14:40:57 -0400
In-Reply-To: <AANLkTimIxCqy7lau-nd8VLfoFjXXFNtf1p7Oem4HjVyS@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, 2010-05-11 at 21:17 +0300, Blue Swirl wrote:
> On 5/10/10, Alex Williamson <alex.williamson@redhat.com> wrote:
> >
> >   hw/pci.c |   17 ++++++++++++-----
> >   1 files changed, 12 insertions(+), 5 deletions(-)
> >
> >  diff --git a/hw/pci.c b/hw/pci.c
> >  index f167436..3d3560e 100644
> >  --- a/hw/pci.c
> >  +++ b/hw/pci.c
> >  @@ -625,6 +625,14 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus,
> >      return pci_dev;
> >   }
> >
> >  +static void do_pci_unregister_device(PCIDevice *pci_dev)
> >  +{
> >  +    qemu_free_irqs(pci_dev->irq);
> >  +    pci_dev->bus->devices[pci_dev->devfn] = NULL;
> >  +    pci_config_free(pci_dev);
> >  +    return;
> 
> Isn't this 'return' useless?

Yeah, I'll remove it.

Alex