* [PATCH 1/2] x86 emulator: Add missing decoder flags for sub instruction
@ 2010-05-11 22:39 Mohammed Gamal
2010-05-11 22:39 ` [PATCH 2/2] x86 emulator: Add missing decoder flags for xor instructions Mohammed Gamal
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Mohammed Gamal @ 2010-05-11 22:39 UTC (permalink / raw)
To: avi; +Cc: mtosatti, kvm, Mohammed Gamal
This adds missing decoder flags for sub instructions (opcodes 0x2c - 0x2d)
Signed-off-by: Mohammed Gamal <m.gamal005@gmail.com>
---
arch/x86/kvm/emulate.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
index be5e78d..5c523ed 100644
--- a/arch/x86/kvm/emulate.c
+++ b/arch/x86/kvm/emulate.c
@@ -126,7 +126,7 @@ static u32 opcode_table[256] = {
/* 0x28 - 0x2F */
ByteOp | DstMem | SrcReg | ModRM | Lock, DstMem | SrcReg | ModRM | Lock,
ByteOp | DstReg | SrcMem | ModRM, DstReg | SrcMem | ModRM,
- 0, 0, 0, 0,
+ ByteOp | DstAcc | SrcImmByte, DstAcc | SrcImm, 0, 0,
/* 0x30 - 0x37 */
ByteOp | DstMem | SrcReg | ModRM | Lock, DstMem | SrcReg | ModRM | Lock,
ByteOp | DstReg | SrcMem | ModRM, DstReg | SrcMem | ModRM,
--
1.7.0.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] x86 emulator: Add missing decoder flags for xor instructions
2010-05-11 22:39 [PATCH 1/2] x86 emulator: Add missing decoder flags for sub instruction Mohammed Gamal
@ 2010-05-11 22:39 ` Mohammed Gamal
2010-05-12 9:37 ` [PATCH 1/2] x86 emulator: Add missing decoder flags for sub instruction Avi Kivity
2010-05-13 18:50 ` Marcelo Tosatti
2 siblings, 0 replies; 5+ messages in thread
From: Mohammed Gamal @ 2010-05-11 22:39 UTC (permalink / raw)
To: avi; +Cc: mtosatti, kvm, Mohammed Gamal
This adds missing decoder flags for xor instructions (opcodes 0x34 - 0x35)
Signed-off-by: Mohammed Gamal <m.gamal005@gmail.com>
---
arch/x86/kvm/emulate.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
index 5c523ed..1650fe5 100644
--- a/arch/x86/kvm/emulate.c
+++ b/arch/x86/kvm/emulate.c
@@ -130,7 +130,7 @@ static u32 opcode_table[256] = {
/* 0x30 - 0x37 */
ByteOp | DstMem | SrcReg | ModRM | Lock, DstMem | SrcReg | ModRM | Lock,
ByteOp | DstReg | SrcMem | ModRM, DstReg | SrcMem | ModRM,
- 0, 0, 0, 0,
+ ByteOp | DstAcc | SrcImmByte, DstAcc | SrcImm, 0, 0,
/* 0x38 - 0x3F */
ByteOp | DstMem | SrcReg | ModRM, DstMem | SrcReg | ModRM,
ByteOp | DstReg | SrcMem | ModRM, DstReg | SrcMem | ModRM,
--
1.7.0.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] x86 emulator: Add missing decoder flags for sub instruction
2010-05-11 22:39 [PATCH 1/2] x86 emulator: Add missing decoder flags for sub instruction Mohammed Gamal
2010-05-11 22:39 ` [PATCH 2/2] x86 emulator: Add missing decoder flags for xor instructions Mohammed Gamal
@ 2010-05-12 9:37 ` Avi Kivity
2010-05-13 18:50 ` Marcelo Tosatti
2 siblings, 0 replies; 5+ messages in thread
From: Avi Kivity @ 2010-05-12 9:37 UTC (permalink / raw)
To: Mohammed Gamal; +Cc: mtosatti, kvm
On 05/12/2010 01:39 AM, Mohammed Gamal wrote:
> This adds missing decoder flags for sub instructions (opcodes 0x2c - 0x2d)
>
>
Looks good (both patches). Please post test cases for realmode.c.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] x86 emulator: Add missing decoder flags for sub instruction
2010-05-11 22:39 [PATCH 1/2] x86 emulator: Add missing decoder flags for sub instruction Mohammed Gamal
2010-05-11 22:39 ` [PATCH 2/2] x86 emulator: Add missing decoder flags for xor instructions Mohammed Gamal
2010-05-12 9:37 ` [PATCH 1/2] x86 emulator: Add missing decoder flags for sub instruction Avi Kivity
@ 2010-05-13 18:50 ` Marcelo Tosatti
2010-05-13 20:26 ` Mohammed Gamal
2 siblings, 1 reply; 5+ messages in thread
From: Marcelo Tosatti @ 2010-05-13 18:50 UTC (permalink / raw)
To: Mohammed Gamal; +Cc: avi, kvm
On Wed, May 12, 2010 at 01:39:21AM +0300, Mohammed Gamal wrote:
> This adds missing decoder flags for sub instructions (opcodes 0x2c - 0x2d)
>
> Signed-off-by: Mohammed Gamal <m.gamal005@gmail.com>
> ---
> arch/x86/kvm/emulate.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Applied both, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] x86 emulator: Add missing decoder flags for sub instruction
2010-05-13 18:50 ` Marcelo Tosatti
@ 2010-05-13 20:26 ` Mohammed Gamal
0 siblings, 0 replies; 5+ messages in thread
From: Mohammed Gamal @ 2010-05-13 20:26 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: avi, kvm
On Thu, May 13, 2010 at 9:50 PM, Marcelo Tosatti <mtosatti@redhat.com> wrote:
> On Wed, May 12, 2010 at 01:39:21AM +0300, Mohammed Gamal wrote:
>> This adds missing decoder flags for sub instructions (opcodes 0x2c - 0x2d)
>>
>> Signed-off-by: Mohammed Gamal <m.gamal005@gmail.com>
>> ---
>> arch/x86/kvm/emulate.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> Applied both, thanks.
>
>
Thanks Marcelo, please also take a look at the test cases for these
instructions that I posted to the mailing list.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-05-13 20:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-11 22:39 [PATCH 1/2] x86 emulator: Add missing decoder flags for sub instruction Mohammed Gamal
2010-05-11 22:39 ` [PATCH 2/2] x86 emulator: Add missing decoder flags for xor instructions Mohammed Gamal
2010-05-12 9:37 ` [PATCH 1/2] x86 emulator: Add missing decoder flags for sub instruction Avi Kivity
2010-05-13 18:50 ` Marcelo Tosatti
2010-05-13 20:26 ` Mohammed Gamal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).