From: Alex Williamson <alex.williamson@redhat.com>
To: Chris Wright <chrisw@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH qemu-kvm 1/2] device-assignment: use stdint types
Date: Thu, 20 May 2010 18:40:10 -0600 [thread overview]
Message-ID: <1274402410.19762.19.camel@localhost> (raw)
In-Reply-To: <20100521002541.GA13880@x200.localdomain>
On Thu, 2010-05-20 at 17:25 -0700, Chris Wright wrote:
> Use stdint types to avoid extra reliance on pci/pci.h header.
>
> Cc: Alex Williamson <alex.williamson@redhat.com>
> Signed-off-by: Chris Wright <chrisw@redhat.com>
> ---
> hw/device-assignment.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
Acked-by: Alex Williamson <alex.williamson@redhat.com>
> diff --git a/hw/device-assignment.c b/hw/device-assignment.c
> index eb31c78..fd09ec3 100644
> --- a/hw/device-assignment.c
> +++ b/hw/device-assignment.c
> @@ -1024,9 +1024,9 @@ static void assigned_dev_update_msi(PCIDevice *pci_dev, unsigned int ctrl_pos)
> static int assigned_dev_update_msix_mmio(PCIDevice *pci_dev)
> {
> AssignedDevice *adev = container_of(pci_dev, AssignedDevice, dev);
> - u16 entries_nr = 0, entries_max_nr;
> + uint16_t entries_nr = 0, entries_max_nr;
> int pos = 0, i, r = 0;
> - u32 msg_addr, msg_upper_addr, msg_data, msg_ctrl;
> + uint32_t msg_addr, msg_upper_addr, msg_data, msg_ctrl;
> struct kvm_assigned_msix_nr msix_nr;
> struct kvm_assigned_msix_entry msix_entry;
> void *va = adev->msix_table_page;
> @@ -1210,7 +1210,7 @@ static int assigned_device_pci_cap_init(PCIDevice *pci_dev)
> /* Expose MSI-X capability */
> if (pci_find_cap_offset(dev->pdev, PCI_CAP_ID_MSIX)) {
> int pos, entry_nr, bar_nr;
> - u32 msix_table_entry;
> + uint32_t msix_table_entry;
> dev->cap.available |= ASSIGNED_DEVICE_CAP_MSIX;
> memset(&pci_dev->config[pci_dev->cap.start + pci_dev->cap.length],
> 0, PCI_CAPABILITY_CONFIG_MSIX_LENGTH);
prev parent reply other threads:[~2010-05-21 0:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-20 13:56 [PATCH] device-assignment: Don't use libpci Alex Williamson
2010-05-20 22:06 ` Chris Wright
2010-05-21 0:23 ` Chris Wright
2010-05-21 0:25 ` [PATCH qemu-kvm 1/2] device-assignment: use stdint types Chris Wright
2010-05-21 0:27 ` [PATCH qemu-kvm 2/2] device-assignment: Don't use libpci Chris Wright
2010-05-21 0:41 ` Alex Williamson
2010-05-23 11:08 ` Avi Kivity
2010-05-21 0:40 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274402410.19762.19.camel@localhost \
--to=alex.williamson@redhat.com \
--cc=chrisw@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox