Re: [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field

Paul Brook
2010-06-10T16:46:07Z

> > > to the identify the device. It should probably do this the same way
> > > that we identify the saved state for the device. Currently I think
> > > this is an arbitrary vmstate name/id, but I expect this to change to a
> > > qdev address (e.g. /i440FX-pcihost/pci.0/_addr_04.0").
> >
> > Ok, that seems fairly reasonable, so from a device pointer we can get
> > something like "/i440FX-pcihost/pci.0/_addr_04.0", then we can add
> > something like ":rom" or ":bar.0" to it via an extra string.
>
> In the fun game of what ifs...
>
> The cmdline starts w/ device A placed at pci bus addr 00:04.0 (so
> matched on source and target). The source does hotunplug of 04.0 and
> replaces it w/ new device. I think we need something that is more
> uniquely identifying the block. Not sure that device name is correct or
> a generation ID.

You shouldn't be solving this problem for RAM blocks. You should be solving it
for the device state.

Paul