From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [RFC PATCH 7/6] savevm: Create a new continue flag to avoid
 resending block name
Date: Tue, 08 Jun 2010 15:32:46 -0600
Message-ID: <1276032766.3079.18.camel@x201>
References: <0100608191447.4451.47795.stgit@localhost.localdomain>
	 <20100608211131.10053.73203.stgit@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: anthony@codemonkey.ws, kvm@vger.kernel.org, quintela@redhat.com,
	chrisw@redhat.com
To: qemu-devel@nongnu.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:27813 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751507Ab0FHVcu (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 8 Jun 2010 17:32:50 -0400
In-Reply-To: <20100608211131.10053.73203.stgit@localhost.localdomain>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, 2010-06-08 at 15:11 -0600, Alex Williamson wrote:
> Allows us to compress the protocol a bit.
...
> @@ -284,6 +290,33 @@ int ram_save_live(Monitor *mon, QEMUFile *f, int stage, void *opaque)
>      return (stage == 2) && (expected_time <= migrate_max_downtime());
>  }
>  
> +static inline void *host_from_stream_offset(QEMUFile *f,
> +                                            ram_addr_t offset,
> +                                            int flags)

This probably shouldn't be inline.  When sending, we'll continue from
COMPRESS or PAGE.  We'd get out of sync on the recv if the compiler
created separate static blocks.  Compiler folks correct me if this can't
happen.

Alex