From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field
Date: Fri, 11 Jun 2010 09:50:31 -0600
Message-ID: <1276271431.3100.26.camel@x201>
References: <20100608191447.4451.47795.stgit@localhost.localdomain>
	 <4C10A106.1050108@redhat.com> <1276180408.2992.12.camel@x201>
	 <201006101549.14094.paul@codesourcery.com> <1276183304.3100.9.camel@x201>
	 <4C11F858.4050904@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: Paul Brook <paul@codesourcery.com>,
	Anthony Liguori <anthony@codemonkey.ws>, qemu-devel@nongnu.org,
	chrisw@redhat.com, kvm@vger.kernel.org, quintela@redhat.com
To: Gerd Hoffmann <kraxel@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:42349 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756976Ab0FKPvI (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 11 Jun 2010 11:51:08 -0400
In-Reply-To: <4C11F858.4050904@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Fri, 2010-06-11 at 10:48 +0200, Gerd Hoffmann wrote:
> On 06/10/10 17:21, Alex Williamson wrote:
> > On Thu, 2010-06-10 at 15:49 +0100, Paul Brook wrote:
> >>> Ok, we can certainly do<vmsd->name>.<vmsd->instance>\<driver string>.
> >>> It seems like this highlights a deficiency in the vmstate matching
> >>
> >> Why are you forcing this to be a string?
> >
> > It seemed like a good way to send an identifier.  What do you suggest?
> 
> Do it the same way savevm handles device state?  I think it simply puts 
> a u32 for the instance id.

I see, so then we'd have:

uint8 - string length (should we decide to go with a variable length)
buffer - "<vmsd->name>\<driver string>"
uint32 - instance_id

I'm not sure I see the benefit to that since then we'd have to do both a
strcmp and an instance_id match.  It's unlikely we'll have instance_ids
large enough that even make it a space savings in the protocol stream
versus "name.id" ("e1000.0").

The trouble I'm running into is that the SaveStateEntry.instance_id is
effectively private, and there's no easy way to associate a
SaveStateEntry to a device since it passes an opaque pointer, which
could be whatever the driver decides it wants.  I'm wondering if we
should pass the DeviceState pointer in when registering the vmstate so
that we can stuff the instance_id into the DeviceInfo.  Or maybe
DeviceInfo should include a pointer to the SaveStateEntry.  It all seems
pretty messy.  Any thoughts?

Alex