Re: [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field

Paul Brook
2010-06-10T14:50:15Z

> On Thu, 2010-06-10 at 10:23 +0200, Gerd Hoffmann wrote:
> > > I may have been a bit misleading here. What we really want to do is use
> > > the same matching algorithm as is used by the rest of the device
> > > state. Currently this is a vmstate name and [arbitrary] numeric id. I
> > > don't remember whether there's a convenient link from a device to its
> > > associated vmstate - if there isn't there probably should be.
> >
> > DeviceState->info->vmsd->name for the name.
> > Dunno about the numeric id, I think savevm.c doesn't export it.
>
> Ok, we can certainly do <vmsd->name>.<vmsd->instance>\<driver string>.
> It seems like this highlights a deficiency in the vmstate matching

Why are you forcing this to be a string?

> Then we start the target, ordering the nics sequentially, are we going
> to store the vmstate into the opposite nics?

That's a separate problem. As long as you use the same matching as for the
rest of the device state then it should just work. If it doesn't work then
migration is already broken so it doen't matter.

Paul