From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Goldish Subject: [KVM-AUTOTEST PATCH 06/14] KVM test: kvm_vm.py: correct get_shared_meminfo() Date: Sun, 13 Jun 2010 17:33:37 +0300 Message-ID: <1276439625-32472-6-git-send-email-mgoldish@redhat.com> References: <1276439625-32472-1-git-send-email-mgoldish@redhat.com> <1276439625-32472-2-git-send-email-mgoldish@redhat.com> <1276439625-32472-3-git-send-email-mgoldish@redhat.com> <1276439625-32472-4-git-send-email-mgoldish@redhat.com> <1276439625-32472-5-git-send-email-mgoldish@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: autotest@test.kernel.org, kvm@vger.kernel.org Return-path: In-Reply-To: <1276439625-32472-5-git-send-email-mgoldish@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: autotest-bounces@test.kernel.org Errors-To: autotest-bounces@test.kernel.org List-Id: kvm.vger.kernel.org - Use open("filename") instead of os.popen("cat filename") - Use self.get_pid() to obtain the PID - Return the result as a float Signed-off-by: Michael Goldish --- client/tests/kvm/kvm_vm.py | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py index 9d3539f..f65d967 100755 --- a/client/tests/kvm/kvm_vm.py +++ b/client/tests/kvm/kvm_vm.py @@ -884,11 +884,10 @@ class VM: logging.error("Could not get shared memory info from dead VM.") return None - cmd = "cat /proc/%d/statm" % self.params.get('pid_' + self.name) - shm = int(os.popen(cmd).readline().split()[2]) + filename = "/proc/%d/statm" % self.get_pid() + shm = int(open(filename).read().split()[2]) # statm stores informations in pages, translate it to MB - shm = shm * 4 / 1024 - return shm + return shm * 4.0 / 1024 def remote_login(self, nic_index=0, timeout=10): -- 1.5.4.1