public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Lalancette <clalance@redhat.com>
To: kvm@vger.kernel.org
Cc: Chris Lalancette <clalance@redhat.com>
Subject: [PATCH v2 3/3] In DM_LOWEST, only deliver interrupts to vcpus with enabled LAPIC's
Date: Mon, 14 Jun 2010 13:11:22 -0400	[thread overview]
Message-ID: <1276535482-11965-4-git-send-email-clalance@redhat.com> (raw)
In-Reply-To: <1276535482-11965-1-git-send-email-clalance@redhat.com>

Otherwise we might try to deliver a timer interrupt to a cpu that
can't possibly handle it.

Signed-off-by: Chris Lalancette <clalance@redhat.com>
---
 virt/kvm/irq_comm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/virt/kvm/irq_comm.c b/virt/kvm/irq_comm.c
index 52f412f..06cf61e 100644
--- a/virt/kvm/irq_comm.c
+++ b/virt/kvm/irq_comm.c
@@ -100,7 +100,7 @@ int kvm_irq_delivery_to_apic(struct kvm *kvm, struct kvm_lapic *src,
 			if (r < 0)
 				r = 0;
 			r += kvm_apic_set_irq(vcpu, irq);
-		} else {
+		} else if (kvm_lapic_enabled(vcpu)) {
 			if (!lowest)
 				lowest = vcpu;
 			else if (kvm_apic_compare_prio(vcpu, lowest) < 0)
-- 
1.6.6.1


      parent reply	other threads:[~2010-06-14 17:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-14 17:11 [PATCH v2 0/3]: Fixes to IRQ routing Chris Lalancette
2010-06-14 17:11 ` [PATCH v2 1/3] Introduce a workqueue to deliver PIT timer interrupts Chris Lalancette
2010-06-14 22:19   ` Marcelo Tosatti
     [not found]     ` <20100615121144.GA2659@localhost.localdomain>
2010-06-15 17:53       ` Marcelo Tosatti
2010-06-15 13:06   ` Gleb Natapov
2010-06-14 17:11 ` [PATCH v2 2/3] Allow any LAPIC to accept PIC interrupts Chris Lalancette
2010-06-14 17:11 ` Chris Lalancette [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1276535482-11965-4-git-send-email-clalance@redhat.com \
    --to=clalance@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox