* [PATCH] device-assignment, msi: PBA is long
@ 2010-06-17 0:34 Hidetoshi Seto
2010-06-17 2:12 ` Alex Williamson
2010-06-18 17:47 ` Marcelo Tosatti
0 siblings, 2 replies; 3+ messages in thread
From: Hidetoshi Seto @ 2010-06-17 0:34 UTC (permalink / raw)
To: kvm; +Cc: Alex Williamson
Accidentally a pci_read_long() was replaced with assigned_dev_pci_read_byte()
by the commit:
commit a81a1f0a7410976be7dbc9a81524a8640f446ab5
Author: Alex Williamson <alex.williamson@redhat.com>
device-assignment: Don't use libpci
Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
---
hw/device-assignment.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/device-assignment.c b/hw/device-assignment.c
index e254203..e237bd3 100644
--- a/hw/device-assignment.c
+++ b/hw/device-assignment.c
@@ -1263,7 +1263,7 @@ static int assigned_device_pci_cap_init(PCIDevice *pci_dev)
pci_dev->cap.length + PCI_MSIX_TABLE) = msix_table_entry;
*(uint32_t *)(pci_dev->config + pci_dev->cap.start +
pci_dev->cap.length + PCI_MSIX_PBA) =
- assigned_dev_pci_read_byte(pci_dev, pos + PCI_MSIX_PBA);
+ assigned_dev_pci_read_long(pci_dev, pos + PCI_MSIX_PBA);
bar_nr = msix_table_entry & PCI_MSIX_BIR;
msix_table_entry &= ~PCI_MSIX_BIR;
dev->msix_table_addr = pci_region[bar_nr].base_addr + msix_table_entry;
--
1.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] device-assignment, msi: PBA is long
2010-06-17 0:34 [PATCH] device-assignment, msi: PBA is long Hidetoshi Seto
@ 2010-06-17 2:12 ` Alex Williamson
2010-06-18 17:47 ` Marcelo Tosatti
1 sibling, 0 replies; 3+ messages in thread
From: Alex Williamson @ 2010-06-17 2:12 UTC (permalink / raw)
To: Hidetoshi Seto; +Cc: kvm
On Thu, 2010-06-17 at 09:34 +0900, Hidetoshi Seto wrote:
> Accidentally a pci_read_long() was replaced with assigned_dev_pci_read_byte()
> by the commit:
> commit a81a1f0a7410976be7dbc9a81524a8640f446ab5
> Author: Alex Williamson <alex.williamson@redhat.com>
> device-assignment: Don't use libpci
>
> Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
> ---
> hw/device-assignment.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Oops.
Acked-by: Alex Williamson <alex.williamson@redhat.com>
> diff --git a/hw/device-assignment.c b/hw/device-assignment.c
> index e254203..e237bd3 100644
> --- a/hw/device-assignment.c
> +++ b/hw/device-assignment.c
> @@ -1263,7 +1263,7 @@ static int assigned_device_pci_cap_init(PCIDevice *pci_dev)
> pci_dev->cap.length + PCI_MSIX_TABLE) = msix_table_entry;
> *(uint32_t *)(pci_dev->config + pci_dev->cap.start +
> pci_dev->cap.length + PCI_MSIX_PBA) =
> - assigned_dev_pci_read_byte(pci_dev, pos + PCI_MSIX_PBA);
> + assigned_dev_pci_read_long(pci_dev, pos + PCI_MSIX_PBA);
> bar_nr = msix_table_entry & PCI_MSIX_BIR;
> msix_table_entry &= ~PCI_MSIX_BIR;
> dev->msix_table_addr = pci_region[bar_nr].base_addr + msix_table_entry;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] device-assignment, msi: PBA is long
2010-06-17 0:34 [PATCH] device-assignment, msi: PBA is long Hidetoshi Seto
2010-06-17 2:12 ` Alex Williamson
@ 2010-06-18 17:47 ` Marcelo Tosatti
1 sibling, 0 replies; 3+ messages in thread
From: Marcelo Tosatti @ 2010-06-18 17:47 UTC (permalink / raw)
To: Hidetoshi Seto; +Cc: kvm, Alex Williamson
On Thu, Jun 17, 2010 at 09:34:36AM +0900, Hidetoshi Seto wrote:
> Accidentally a pci_read_long() was replaced with assigned_dev_pci_read_byte()
> by the commit:
> commit a81a1f0a7410976be7dbc9a81524a8640f446ab5
> Author: Alex Williamson <alex.williamson@redhat.com>
> device-assignment: Don't use libpci
>
> Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
> ---
> hw/device-assignment.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-06-18 19:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-17 0:34 [PATCH] device-assignment, msi: PBA is long Hidetoshi Seto
2010-06-17 2:12 ` Alex Williamson
2010-06-18 17:47 ` Marcelo Tosatti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox