From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [PATCH] device-assignment, msi: PBA is long Date: Wed, 16 Jun 2010 20:12:35 -0600 Message-ID: <1276740755.12015.975.camel@x201> References: <4C196D9C.5010903@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Hidetoshi Seto Return-path: Received: from mx1.redhat.com ([209.132.183.28]:51088 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756642Ab0FQCMj (ORCPT ); Wed, 16 Jun 2010 22:12:39 -0400 In-Reply-To: <4C196D9C.5010903@jp.fujitsu.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, 2010-06-17 at 09:34 +0900, Hidetoshi Seto wrote: > Accidentally a pci_read_long() was replaced with assigned_dev_pci_read_byte() > by the commit: > commit a81a1f0a7410976be7dbc9a81524a8640f446ab5 > Author: Alex Williamson > device-assignment: Don't use libpci > > Signed-off-by: Hidetoshi Seto > --- > hw/device-assignment.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Oops. Acked-by: Alex Williamson > diff --git a/hw/device-assignment.c b/hw/device-assignment.c > index e254203..e237bd3 100644 > --- a/hw/device-assignment.c > +++ b/hw/device-assignment.c > @@ -1263,7 +1263,7 @@ static int assigned_device_pci_cap_init(PCIDevice *pci_dev) > pci_dev->cap.length + PCI_MSIX_TABLE) = msix_table_entry; > *(uint32_t *)(pci_dev->config + pci_dev->cap.start + > pci_dev->cap.length + PCI_MSIX_PBA) = > - assigned_dev_pci_read_byte(pci_dev, pos + PCI_MSIX_PBA); > + assigned_dev_pci_read_long(pci_dev, pos + PCI_MSIX_PBA); > bar_nr = msix_table_entry & PCI_MSIX_BIR; > msix_table_entry &= ~PCI_MSIX_BIR; > dev->msix_table_addr = pci_region[bar_nr].base_addr + msix_table_entry;