public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Lucas Meneghel Rodrigues <lmr@redhat.com>
To: autotest@test.kernel.org, mgoldish@redhat.com
Cc: kvm@vger.kernel.org
Subject: [PATCH 2/5] KVM test: add boolean 'testdev' VM parameter for RHEL-6 style unit tests
Date: Thu, 24 Jun 2010 20:33:03 -0300	[thread overview]
Message-ID: <1277422386-13516-2-git-send-email-lmr@redhat.com> (raw)
In-Reply-To: <1277422386-13516-1-git-send-email-lmr@redhat.com>

Should be set to "yes" to enable testdev.

Signed-off-by: Michael Goldish <mgoldish@redhat.com>
---
 client/tests/kvm/kvm_vm.py |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py
index 87b037f..7b1fc05 100755
--- a/client/tests/kvm/kvm_vm.py
+++ b/client/tests/kvm/kvm_vm.py
@@ -290,6 +290,10 @@ class VM:
         def add_kernel_cmdline(help, cmdline):
             return " -append %s" % cmdline
 
+        def add_testdev(help, filename):
+            return (" -chardev file,id=testlog,path=%s"
+                    " -device testdev,chardev=testlog" % filename)
+
         # End of command line option wrappers
 
         if name is None: name = self.name
@@ -424,6 +428,9 @@ class VM:
         elif params.get("uuid"):
             qemu_cmd += add_uuid(help, params.get("uuid"))
 
+        if params.get("testdev") == "yes":
+            qemu_cmd += add_testdev(help, self.get_testlog_filename())
+
         # If the PCI assignment step went OK, add each one of the PCI assigned
         # devices to the qemu command line.
         if self.pci_assignable:
-- 
1.7.0.1

  reply	other threads:[~2010-06-24 23:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-24 23:33 [PATCH 1/5] KVM test: support kernel -append command line options Lucas Meneghel Rodrigues
2010-06-24 23:33 ` Lucas Meneghel Rodrigues [this message]
2010-06-24 23:33 ` [PATCH 3/5] KVM test: add wrapper for RHEL-6 style unittests Lucas Meneghel Rodrigues
2010-06-25 14:26   ` Michael Goldish
2010-06-24 23:33 ` [PATCH 4/5] KVM test: add sample RHEL-6 style unittest config file Lucas Meneghel Rodrigues
2010-06-24 23:33 ` [PATCH 5/5] KVM test: Make it possible to run VMs without NICs Lucas Meneghel Rodrigues
2010-06-25 10:03   ` Michael Goldish

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1277422386-13516-2-git-send-email-lmr@redhat.com \
    --to=lmr@redhat.com \
    --cc=autotest@test.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=mgoldish@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox