Re: [PATCH 12/26] KVM: PPC: First magic page steps

Alexander Graf
2010-06-27T09:43:45Z

Am 27.06.2010 um 10:24 schrieb Avi Kivity <avi@redhat.com>:

> On 06/26/2010 02:25 AM, Alexander Graf wrote:
>> We will be introducing a method to project the shared page in guest
>> context.
>> As soon as we're talking about this coupling, the shared page is
>> colled magic
>> page.
>>
>> This patch introduces simple defines, so the follow-up patches are
>> easier to
>> read.
>>
>>
>>
>> diff --git a/arch/powerpc/include/asm/kvm_host.h b/arch/powerpc/
>> include/asm/kvm_host.h
>> index e35c1ac..5f8c214 100644
>> --- a/arch/powerpc/include/asm/kvm_host.h
>> +++ b/arch/powerpc/include/asm/kvm_host.h
>> @@ -285,6 +285,8 @@ struct kvm_vcpu_arch {
>> u64 dec_jiffies;
>> unsigned long pending_exceptions;
>> struct kvm_vcpu_arch_shared *shared;
>> + unsigned long magic_page_pa; /* phys addr to map the magic
>> page to */
>> + unsigned long magic_page_ea; /* effect. addr to map the magic
>> page to */
>>
>
> Is ea like a va? If so, can't the guest specify it by manipulating
> the hash table (or tlb)?

ea in ppc speech is va in x86 speech. Yes, the guest could map it
itself, but I couldn't find out how. This way I at least know what's
happening :).

Alex