Re: [PATCH 01/26] KVM: PPC: Introduce shared page

Avi Kivity
2010-06-29T10:55:35Z

On 06/29/2010 12:54 PM, Alexander Graf wrote:
>
>> Code repeats 3x. Share please.
>>
> Looking at this again, I could combine the 3 lines of init code into 3
> lines of code that do a generic function call and then error checking.
> And I could convert the one free_page line with one function call that
> would free the page. Is there a real gain behind this?
>
>

Looks marginal, yes. It will help if initialization is expanded later,
but currently it doesn't help much.

--
error compiling committee.c: too many arguments to function