From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alexander Graf <agraf@suse.de>
Cc: "kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Avi Kivity <avi@redhat.com>, KVM list <kvm@vger.kernel.org>
Subject: Re: [PATCH 18/26] KVM: PPC: KVM PV guest stubs
Date: Mon, 28 Jun 2010 08:04:59 +1000 [thread overview]
Message-ID: <1277676299.4200.132.camel@pasglop> (raw)
In-Reply-To: <0E529B3E-541C-4E3B-81E7-AACCD96CBF2C@suse.de>
On Sun, 2010-06-27 at 11:47 +0200, Alexander Graf wrote:
> I did that at first. It breaks. During the patching we may take
> interrupts (pahe faults for example) that contain just patched
> instructions. And really, hell breaks loose if we don't flush it
> immediately :). I was hoping at first a 32 bit replace would be
> atomic
> in cache, but the cpu tried to execute invalid instructions, so it
> must have gotten some intermediate state.
A 32-bit aligned store -is- atomic. The other threads/cpu will see
either the old or the new instruction, nothing in between.
Cheers,
Ben.
next prev parent reply other threads:[~2010-06-27 22:04 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-25 23:24 [PATCH 00/26] KVM PPC PV framework Alexander Graf
2010-06-25 23:24 ` [PATCH 01/26] KVM: PPC: Introduce shared page Alexander Graf
[not found] ` <1277508314-915-2-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2010-06-27 12:12 ` Avi Kivity
[not found] ` <4C274028.7020105-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-06-29 9:54 ` Alexander Graf
2010-06-29 10:55 ` Avi Kivity
2010-06-25 23:24 ` [PATCH 03/26] KVM: PPC: Convert DSISR to " Alexander Graf
2010-06-25 23:24 ` [PATCH 05/26] KVM: PPC: Convert SRR0 and SRR1 " Alexander Graf
2010-06-25 23:24 ` [PATCH 06/26] KVM: PPC: Convert SPRG[0-4] " Alexander Graf
2010-06-25 23:24 ` [PATCH 07/26] KVM: PPC: Implement hypervisor interface Alexander Graf
[not found] ` <1277508314-915-1-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2010-06-25 23:24 ` [PATCH 02/26] KVM: PPC: Convert MSR to shared page Alexander Graf
[not found] ` <1277508314-915-3-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2010-06-27 8:16 ` Avi Kivity
[not found] ` <4C2708EB.9020500-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-06-27 9:38 ` Alexander Graf
[not found] ` <651805F1-54AB-466F-8D23-D053D8082177-l3A5Bk7waGM@public.gmane.org>
2010-06-27 9:50 ` Avi Kivity
[not found] ` <4C271EE5.1060401-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-06-27 10:40 ` Alexander Graf
2010-06-25 23:24 ` [PATCH 04/26] KVM: PPC: Convert DAR " Alexander Graf
2010-06-25 23:24 ` [PATCH 08/26] KVM: PPC: Add PV guest critical sections Alexander Graf
[not found] ` <1277508314-915-9-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2010-06-27 8:21 ` Avi Kivity
[not found] ` <4C2709F4.10805-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-06-27 9:40 ` Alexander Graf
2010-06-27 9:52 ` Avi Kivity
2010-06-27 10:33 ` Alexander Graf
[not found] ` <DFC77851-3BE7-4746-93DE-287D5E27EF7D-l3A5Bk7waGM@public.gmane.org>
2010-06-27 10:59 ` Avi Kivity
[not found] ` <4C272F08.8090709-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-06-27 11:49 ` Alexander Graf
2010-06-27 11:53 ` Avi Kivity
[not found] ` <4C273BAD.2090305-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-06-27 12:06 ` Alexander Graf
2010-06-27 22:03 ` Benjamin Herrenschmidt
2010-06-27 10:03 ` Avi Kivity
[not found] ` <4C27220D.7090508-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-06-27 10:35 ` Alexander Graf
2010-06-25 23:25 ` [PATCH 13/26] KVM: PPC: Magic Page Book3s support Alexander Graf
2010-06-25 23:25 ` [PATCH 14/26] KVM: PPC: Magic Page BookE support Alexander Graf
2010-06-25 23:25 ` [PATCH 17/26] KVM: PPC: Generic KVM PV guest support Alexander Graf
2010-06-25 23:25 ` [PATCH 19/26] KVM: PPC: PV instructions to loads and stores Alexander Graf
2010-06-25 23:25 ` [PATCH 20/26] KVM: PPC: PV tlbsync to nop Alexander Graf
2010-06-25 23:25 ` [PATCH 22/26] KVM: PPC: PV assembler helpers Alexander Graf
2010-06-25 23:25 ` [PATCH 24/26] KVM: PPC: PV mtmsrd L=0 and mtmsr Alexander Graf
[not found] ` <1277508314-915-25-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2010-06-26 17:03 ` Segher Boessenkool
[not found] ` <EDF0A567-C440-4F1B-9AF5-2E0F8203D566-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2010-06-27 9:10 ` Alexander Graf
2010-06-29 7:37 ` Segher Boessenkool
2010-06-25 23:25 ` [PATCH 26/26] KVM: PPC: Add Documentation about PV interface Alexander Graf
2010-06-27 8:14 ` Avi Kivity
[not found] ` <4C270876.2050806-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-06-27 9:33 ` Alexander Graf
2010-06-28 7:18 ` Milton Miller
[not found] ` <1277709531_13308-qolCYAvwHvWlVDA81TZ6el6hYfS7NtTn@public.gmane.org>
2010-06-28 7:49 ` Alexander Graf
[not found] ` <92F4A3F3-A89F-418D-BD4D-66E2489F2E42-l3A5Bk7waGM@public.gmane.org>
2010-06-28 8:13 ` Avi Kivity
[not found] ` <4C285991.1050303-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-06-28 8:21 ` Alexander Graf
[not found] ` <4330E5DC-63C5-40EA-9E99-34EE58074D1A-l3A5Bk7waGM@public.gmane.org>
2010-06-28 8:32 ` Avi Kivity
[not found] ` <1277508314-915-27-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2010-06-27 8:34 ` Avi Kivity
2010-06-27 9:49 ` Alexander Graf
2010-06-25 23:24 ` [PATCH 09/26] KVM: PPC: Add PV guest scratch registers Alexander Graf
[not found] ` <1277508314-915-10-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2010-06-27 8:22 ` Avi Kivity
[not found] ` <4C270A34.4020706-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-06-27 9:41 ` Alexander Graf
[not found] ` <27BB673F-F34E-4CC6-A22D-02CF95E7529F-l3A5Bk7waGM@public.gmane.org>
2010-06-27 9:53 ` Avi Kivity
2010-06-25 23:24 ` [PATCH 10/26] KVM: PPC: Tell guest about pending interrupts Alexander Graf
2010-06-25 23:24 ` [PATCH 11/26] KVM: PPC: Make RMO a define Alexander Graf
[not found] ` <1277508314-915-12-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2010-06-26 16:52 ` Segher Boessenkool
[not found] ` <2078D8A9-7D36-4B5D-A779-9BBAB545A53D-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2010-06-27 9:08 ` Alexander Graf
[not found] ` <9B84B663-7DC6-4543-96F7-23F77106065C-l3A5Bk7waGM@public.gmane.org>
2010-06-29 7:32 ` Segher Boessenkool
[not found] ` <07830DA6-1B53-4E84-A0E2-8449289C71F1-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2010-06-29 7:39 ` Alexander Graf
2010-06-29 7:52 ` Segher Boessenkool
[not found] ` <1550A5F0-3A22-48ED-8251-96328E2FEAE3-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2010-06-29 8:04 ` Alexander Graf
2010-06-25 23:25 ` [PATCH 12/26] KVM: PPC: First magic page steps Alexander Graf
[not found] ` <1277508314-915-13-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2010-06-27 8:24 ` Avi Kivity
2010-06-27 9:44 ` Alexander Graf
2010-06-25 23:25 ` [PATCH 15/26] KVM: PPC: Expose magic page support to guest Alexander Graf
2010-06-25 23:25 ` [PATCH 16/26] KVM: Move kvm_guest_init out of generic code Alexander Graf
2010-06-25 23:25 ` [PATCH 18/26] KVM: PPC: KVM PV guest stubs Alexander Graf
[not found] ` <1277508314-915-19-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2010-06-27 8:28 ` Avi Kivity
[not found] ` <4C270BB8.60404-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-06-27 9:47 ` Alexander Graf
2010-06-27 10:16 ` Avi Kivity
[not found] ` <4C272503.7030605-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-06-27 10:38 ` Alexander Graf
2010-06-27 22:04 ` Benjamin Herrenschmidt [this message]
2010-06-28 4:39 ` Matt Evans
[not found] ` <4C282794.1040209-mnsaURCQ41sdnm+yROfE0A@public.gmane.org>
2010-06-28 6:33 ` Alexander Graf
2010-06-28 8:15 ` Avi Kivity
[not found] ` <4C285A13.8070208-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-06-28 8:23 ` Alexander Graf
[not found] ` <AD79CD04-74CF-49B9-BACC-4C190DF5214A-l3A5Bk7waGM@public.gmane.org>
2010-06-28 8:33 ` Avi Kivity
2010-06-25 23:25 ` [PATCH 21/26] KVM: PPC: Introduce kvm_tmp framework Alexander Graf
2010-06-25 23:25 ` [PATCH 23/26] KVM: PPC: PV mtmsrd L=1 Alexander Graf
2010-06-25 23:25 ` [PATCH 25/26] KVM: PPC: PV wrteei Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277676299.4200.132.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=agraf@suse.de \
--cc=avi@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox