Re: [PATCH 27/27] KVM: PPC: Add Documentation about PV interface

Avi Kivity
2010-07-04T09:41:14Z

On 07/04/2010 12:30 PM, Alexander Graf wrote:
>
>> Considering how the parts of the draft that I read about sound like, that's not the inventor's idea. PPC people love to see the BIOS be part of the virtualization solution. I don't. That's the biggest difference here and reason for us going different directions.
>>
>> I think what they thought of is something like
>>
>> if (in_kvm()) {
>> device_tree_put("/hypervisor/exit", EXIT_TYPE_MAGIC);
>> device_tree_put("/hypervisor/exit_magic", EXIT_MAGIC);
>> }
>>
>> which then the OS reads out. But that's useless, as the hypercalls are hypervisor specific. So why make the detection on the Linux side generic?
>>
> In fact, it's even worse. Right now with KVM for PPC we have 3 different ways of generating the device tree:
>
> 1) OpenBIOS (Mac emulation)
> 2) Qemu libfdt (BookE)
> 3) MOL OF implementation
>

I sympathize. But, if the arch says that's how you do things, then
that's how you do things.

> So I'd have to touch even more projects. Just for the sake of splitting out something that belongs together anyway. And probably even create new interfaces just for that sake (qemu asking the kernel which type of hypercalls the vm should use) even though the guest could just query all that itself.
>

qemu needs to be involved, in case one day you support more than one
type of hypercalls (like x86 does with hyper-v) or if you want to live
migrate from a host that has hypercall support to another host that has
this feature removed (as has already happened on x86 with the pvmmu).

Planning for the future means a lot of boring interfaces.

--
error compiling committee.c: too many arguments to function