From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [PATCH V2] VFIO driver: Non-privileged user level PCI drivers Date: Thu, 01 Jul 2010 09:29:04 -0600 Message-ID: <1277998144.10112.58.camel@x201> References: <4c0eb470.1HMjondO00NIvFM6%pugs@cisco.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: randy.dunlap@oracle.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, chrisw@sous-sol.org, joro@8bytes.org, hjk@linutronix.de, mst@redhat.com, avi@redhat.com, gregkh@suse.de, aafabbri@cisco.com, scofeldm@cisco.com, Donald Dutile To: Tom Lyon Return-path: In-Reply-To: <4c0eb470.1HMjondO00NIvFM6%pugs@cisco.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Tue, 2010-06-08 at 14:21 -0700, Tom Lyon wrote: > +The VFIO_DMA_MASK ioctl is used to set the maximum permissible DMA address > +(device dependent). It takes a single unsigned 64 bit integer as an argument. > +This call also has the side effect of enabling PCI bus mastership. Hi Tom, This interface doesn't make sense for the MAP_IOVA user. Especially in qemu, we have no idea what the DMA mask is for the device we're assigning. It doesn't really matter though because the guest will use bounce buffers internally once it loads the device specific drivers and discovers the DMA mask. This only seems relevant if we're using a DMA_MAP call that gets to pick the dmaaddr, so I'd propose we only make this a required call for that interface, and create a separate ioctl for actually enabling bus master. Thanks, Alex