From: Lucas Meneghel Rodrigues <lmr@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: autotest@test.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM test: Disable HPET on windows timedrift tests
Date: Thu, 01 Jul 2010 13:05:06 -0300 [thread overview]
Message-ID: <1278000306.2659.264.camel@freedom> (raw)
In-Reply-To: <4C2CA956.6010002@redhat.com>
On Thu, 2010-07-01 at 17:42 +0300, Avi Kivity wrote:
> On 06/30/2010 06:39 PM, Lucas Meneghel Rodrigues wrote:
> > By default, HPET is enabled on qemu and no time drift
> > mitigation is being made for it. So, add -no-hpet
> > if qemu supports it, during windows timedrift tests.
> >
> >
>
> Hm, you're compensating for a qemu bug by not testing it.
>
> Can we have an XFAIL for this test instead?
Certainly we can. In actuality, that's what's being done on our internal
autotest server - this particular test is linked to the upstream bug
https://bugs.launchpad.net/qemu/+bug/599958
We've discussed about this issue this morning, it boils down to the way
people are more comfortable with handling this issue. My first thought
was to disable HPET until someone come up with a time drift mitigation
strategy for it.
But your approach makes more sense, unless someone has something else to
say about it, I'll drop the patch from autotest shortly.
Lucas
next prev parent reply other threads:[~2010-07-01 16:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-30 15:39 [PATCH] KVM test: Disable HPET on windows timedrift tests Lucas Meneghel Rodrigues
2010-07-01 14:42 ` Avi Kivity
2010-07-01 16:05 ` Lucas Meneghel Rodrigues [this message]
2010-07-04 6:32 ` Dor Laor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278000306.2659.264.camel@freedom \
--to=lmr@redhat.com \
--cc=autotest@test.kernel.org \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox