From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Meneghel Rodrigues Subject: Re: [PATCH] KVM test: Disable HPET on windows timedrift tests Date: Thu, 01 Jul 2010 13:05:06 -0300 Message-ID: <1278000306.2659.264.camel@freedom> References: <1277912395-10671-1-git-send-email-lmr@redhat.com> <4C2CA956.6010002@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: autotest@test.kernel.org, kvm@vger.kernel.org To: Avi Kivity Return-path: In-Reply-To: <4C2CA956.6010002@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: autotest-bounces@test.kernel.org Errors-To: autotest-bounces@test.kernel.org List-Id: kvm.vger.kernel.org On Thu, 2010-07-01 at 17:42 +0300, Avi Kivity wrote: > On 06/30/2010 06:39 PM, Lucas Meneghel Rodrigues wrote: > > By default, HPET is enabled on qemu and no time drift > > mitigation is being made for it. So, add -no-hpet > > if qemu supports it, during windows timedrift tests. > > > > > > Hm, you're compensating for a qemu bug by not testing it. > > Can we have an XFAIL for this test instead? Certainly we can. In actuality, that's what's being done on our internal autotest server - this particular test is linked to the upstream bug https://bugs.launchpad.net/qemu/+bug/599958 We've discussed about this issue this morning, it boils down to the way people are more comfortable with handling this issue. My first thought was to disable HPET until someone come up with a time drift mitigation strategy for it. But your approach makes more sense, unless someone has something else to say about it, I'll drop the patch from autotest shortly. Lucas