kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Huang Ying <ying.huang@intel.com>
To: Avi Kivity <avi@redhat.com>
Cc: kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH 1/2] KVM: Expose MCE control MSRs to userspace
Date: Thu, 08 Jul 2010 16:03:48 +0800	[thread overview]
Message-ID: <1278576228.2783.114.camel@yhuang-dev.sh.intel.com> (raw)
In-Reply-To: <4C3581AB.8030404@redhat.com>

On Thu, 2010-07-08 at 15:43 +0800, Avi Kivity wrote:
> On 07/08/2010 05:07 AM, Huang Ying wrote:
> >
> >>   static u32 emulated_msrs[] = {
> >>   	MSR_IA32_MISC_ENABLE,
> >> +	MSR_IA32_MCG_STATUS,
> >> +	MSR_IA32_MCG_CTL,
> >>      
> > We need only clear MSR_IA32_MCG_STATUS during reset, but should not
> > clear MSR_IA32_MCG_CTL.
> >
> >    
> 
> Why not?

According to Intel 64 and IA32 Architectures Software Developer's Manual
(SDM) Vol 3A (Table 9-1), machine check MSRs should be sticky across
reset. Except we need some special processing for MSR_IA32_MCG_STATUS.

And if we clear MSR_IA32_MCG_CTL, the machine check reporting is
disabled according to SDM Vol 3A, section 15.3.1.3

Best Regards,
Huang Ying



  reply	other threads:[~2010-07-08  8:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-07 11:09 [PATCH 0/2] Fix MCE not cleared on reset Avi Kivity
2010-07-07 11:09 ` [PATCH 1/2] KVM: Expose MCE control MSRs to userspace Avi Kivity
2010-07-08  2:07   ` Huang Ying
2010-07-08  7:43     ` Avi Kivity
2010-07-08  8:03       ` Huang Ying [this message]
2010-07-08  8:16         ` Avi Kivity
2010-07-08  8:47           ` Huang Ying
2010-07-08  9:12             ` Avi Kivity
2010-07-12  0:10               ` Huang Ying
2010-07-07 11:09 ` [PATCH 2/2] KVM: Document MCE banks non-exposure via KVM_GET_MSR_INDEX_LIST Avi Kivity
2010-07-12 18:05 ` [PATCH 0/2] Fix MCE not cleared on reset Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1278576228.2783.114.camel@yhuang-dev.sh.intel.com \
    --to=ying.huang@intel.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).