kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mohammed Gamal <m.gamal005@gmail.com>
To: avi@redhat.com
Cc: mtosatti@redhat.com, kvm@vger.kernel.org,
	Mohammed Gamal <m.gamal005@gmail.com>
Subject: [RFC PATCH v2 0/3] Add segment limit checks to emulator
Date: Thu,  8 Jul 2010 17:10:33 +0300	[thread overview]
Message-ID: <1278598236-12103-1-git-send-email-m.gamal005@gmail.com> (raw)

After some conversation with Avi concerning why unreal mode has been seen to work
with KVM on Intel. It clears out the scenario is caused as follows:

- guest enters big real mode
- kvm squashes limit to 64k-1
- guest executes instructions with offset > 64k
- cpu issues #GP due to limit violation
- kvm handle_rmode_exception() -> emulator
- emulator ignores limit, emulates instruction

With these applied I am getting vmentry failures with SeaBIOS and
gPXE. I could still get SeaBIOS to work with emulate_invalid_guest_state=1.
So it's needless to say that these patches are not meant for merging!

--------

Changes from v1:
- Added seg_override_limit() and emulate_ss() helpers in emulator
- Corrected limit check return values for long mode
- Limit Checking is now consistent with the Intel documentation

--------

Mohammed Gamal (3):
  Add helper methods to get segment limits
  x86 emulator: Add cs_base() helper
  x86 emulator: Add segment limit checks and helper functions

 arch/x86/include/asm/kvm_emulate.h |    1 +
 arch/x86/include/asm/kvm_host.h    |    1 +
 arch/x86/kvm/emulate.c             |  143 ++++++++++++++++++++++++++++++------
 arch/x86/kvm/svm.c                 |    8 ++
 arch/x86/kvm/vmx.c                 |    8 ++
 arch/x86/kvm/x86.c                 |   12 +++
 6 files changed, 150 insertions(+), 23 deletions(-)


             reply	other threads:[~2010-07-08 14:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-08 14:10 Mohammed Gamal [this message]
2010-07-08 14:10 ` [RFC PATCH v2 1/3] Add helper methods to get segment limits Mohammed Gamal
2010-07-08 14:10 ` [RFC PATCH v2 2/3] x86 emulator: Add cs_base() helper Mohammed Gamal
2010-07-08 14:10 ` [RFC PATCH v2 3/3] x86 emulator: Add segment limit checks and helper functions Mohammed Gamal
2010-07-11 18:07   ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1278598236-12103-1-git-send-email-m.gamal005@gmail.com \
    --to=m.gamal005@gmail.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).