From: Alessandro Bono <alessandro.bono@gmail.com>
To: Brian Jackson <iggy@theiggy.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] increase MAX_NICS value
Date: Mon, 12 Jul 2010 14:54:51 +0200 [thread overview]
Message-ID: <1278939291.9543.6.camel@champagne> (raw)
In-Reply-To: <201007091230.58502.iggy@theiggy.com>
On Fri, 2010-07-09 at 12:30 -0500, Brian Jackson wrote:
> On Friday, July 09, 2010 10:39:17 am Alessandro Bono wrote:
> > Hi all
> >
> > max number of allowed nics per vm is hardcoded on net.h to 8. This value
> > it's too low in situation with big network, increase to 24
> > this should be safe as mentioned on this thread
> > http://kerneltrap.org/mailarchive/linux-kvm/2009/1/29/4848304/thread
>
>
> A better long term solution might be to convert it to QLIST or something
> instead of hardcoding the array size.
Sure my patch it's simply a better default value and solve the problem
for big network. Obviously a dynamic structure it's best suited for this
information
>
>
> >
> > Signed-off-by: Alessandro Bono <alessandro.bono@gmail.com>
> >
> > --- net.h.old 2010-07-09 17:30:39.542170103 +0200
> > +++ net.h 2010-07-09 17:30:48.842166029 +0200
> > @@ -121,7 +121,7 @@
> >
> > /* NIC info */
> >
> > -#define MAX_NICS 8
> > +#define MAX_NICS 24
> >
> > struct NICInfo {
> > uint8_t macaddr[6];
--
Cordiali Saluti
Alessandro Bono
next prev parent reply other threads:[~2010-07-12 12:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-09 15:39 [PATCH] increase MAX_NICS value Alessandro Bono
2010-07-09 17:30 ` Brian Jackson
2010-07-12 12:54 ` Alessandro Bono [this message]
2010-07-10 5:59 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278939291.9543.6.camel@champagne \
--to=alessandro.bono@gmail.com \
--cc=iggy@theiggy.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox