From: Gleb Natapov <gleb@redhat.com>
To: mtosatti@redhat.com, avi@redhat.com
Cc: kvm@vger.kernel.org
Subject: [PATCH 1/2] KVM: x86 emulator: don't update vcpu state if instruction is restarted.
Date: Thu, 29 Jul 2010 15:11:52 +0300 [thread overview]
Message-ID: <1280405513-579-2-git-send-email-gleb@redhat.com> (raw)
In-Reply-To: <1280405513-579-1-git-send-email-gleb@redhat.com>
No need to update vcpu state since instruction is in the middle of the
emulation.
Signed-off-by: Gleb Natapov <gleb@redhat.com>
---
arch/x86/kvm/x86.c | 31 +++++++++++++------------------
1 files changed, 13 insertions(+), 18 deletions(-)
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 76fbc32..7e5f075 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -4057,32 +4057,27 @@ restart:
return handle_emulation_failure(vcpu);
}
- toggle_interruptibility(vcpu, vcpu->arch.emulate_ctxt.interruptibility);
- kvm_x86_ops->set_rflags(vcpu, vcpu->arch.emulate_ctxt.eflags);
- memcpy(vcpu->arch.regs, c->regs, sizeof c->regs);
- kvm_rip_write(vcpu, vcpu->arch.emulate_ctxt.eip);
+ r = EMULATE_DONE;
- if (vcpu->arch.emulate_ctxt.exception >= 0) {
+ if (vcpu->arch.emulate_ctxt.exception >= 0)
inject_emulated_exception(vcpu);
- return EMULATE_DONE;
- }
-
- if (vcpu->arch.pio.count) {
+ else if (vcpu->arch.pio.count) {
if (!vcpu->arch.pio.in)
vcpu->arch.pio.count = 0;
- return EMULATE_DO_MMIO;
- }
-
- if (vcpu->mmio_needed) {
+ r = EMULATE_DO_MMIO;
+ } else if (vcpu->mmio_needed) {
if (vcpu->mmio_is_write)
vcpu->mmio_needed = 0;
- return EMULATE_DO_MMIO;
- }
-
- if (vcpu->arch.emulate_ctxt.restart)
+ r = EMULATE_DO_MMIO;
+ } else if (vcpu->arch.emulate_ctxt.restart)
goto restart;
- return EMULATE_DONE;
+ toggle_interruptibility(vcpu, vcpu->arch.emulate_ctxt.interruptibility);
+ kvm_x86_ops->set_rflags(vcpu, vcpu->arch.emulate_ctxt.eflags);
+ memcpy(vcpu->arch.regs, c->regs, sizeof c->regs);
+ kvm_rip_write(vcpu, vcpu->arch.emulate_ctxt.eip);
+
+ return r;
}
EXPORT_SYMBOL_GPL(emulate_instruction);
--
1.7.1
next prev parent reply other threads:[~2010-07-29 12:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-29 12:11 [PATCH 0/2] Speedup ins instruction emulation a little Gleb Natapov
2010-07-29 12:11 ` Gleb Natapov [this message]
2010-07-31 17:25 ` [PATCH 1/2] KVM: x86 emulator: don't update vcpu state if instruction is restarted Avi Kivity
2010-08-01 8:28 ` Gleb Natapov
2010-08-01 8:54 ` Avi Kivity
2010-08-01 9:01 ` Gleb Natapov
2010-08-01 9:14 ` Avi Kivity
2010-08-01 9:24 ` Gleb Natapov
2010-08-01 10:00 ` Avi Kivity
2010-08-01 10:53 ` Gleb Natapov
2010-08-01 12:17 ` Avi Kivity
2010-08-01 12:23 ` Gleb Natapov
2010-08-01 12:35 ` Avi Kivity
2010-08-01 13:27 ` Gleb Natapov
2010-08-02 5:04 ` Avi Kivity
2010-08-02 7:58 ` Gleb Natapov
2010-08-02 8:03 ` Avi Kivity
2010-08-02 8:17 ` Gleb Natapov
2010-08-02 8:24 ` Avi Kivity
2010-08-02 8:34 ` Gleb Natapov
2010-08-02 8:54 ` Avi Kivity
2010-08-02 9:05 ` Gleb Natapov
2010-08-02 9:08 ` Avi Kivity
2010-07-29 12:11 ` [PATCH 2/2] KVM: x86 emulator: check io permissions only once for string pio Gleb Natapov
2010-07-31 1:59 ` Marcelo Tosatti
2010-07-29 12:19 ` [PATCH 0/2] Speedup ins instruction emulation a little Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280405513-579-2-git-send-email-gleb@redhat.com \
--to=gleb@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox