public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Gleb Natapov <gleb@redhat.com>
To: mtosatti@redhat.com, avi@redhat.com
Cc: kvm@vger.kernel.org
Subject: [PATCH 2/2] KVM: x86 emulator: check io permissions only once for string pio
Date: Thu, 29 Jul 2010 15:11:53 +0300	[thread overview]
Message-ID: <1280405513-579-3-git-send-email-gleb@redhat.com> (raw)
In-Reply-To: <1280405513-579-1-git-send-email-gleb@redhat.com>

Do not recheck io permission on every iteration.

Signed-off-by: Gleb Natapov <gleb@redhat.com>
---
 arch/x86/include/asm/kvm_emulate.h |    1 +
 arch/x86/kvm/emulate.c             |    6 ++++++
 arch/x86/kvm/x86.c                 |    1 +
 3 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/arch/x86/include/asm/kvm_emulate.h b/arch/x86/include/asm/kvm_emulate.h
index 51cfd73..ded05cf 100644
--- a/arch/x86/include/asm/kvm_emulate.h
+++ b/arch/x86/include/asm/kvm_emulate.h
@@ -216,6 +216,7 @@ struct x86_emulate_ctxt {
 	int interruptibility;
 
 	bool restart; /* restart string instruction after writeback */
+	bool perm_ok; /* do not check permissions if true */
 
 	int exception; /* exception that happens during emulation or -1 */
 	u32 error_code; /* error code for exception */
diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
index b38bd8b..3996fb0 100644
--- a/arch/x86/kvm/emulate.c
+++ b/arch/x86/kvm/emulate.c
@@ -2161,9 +2161,15 @@ static bool emulator_io_permited(struct x86_emulate_ctxt *ctxt,
 				 struct x86_emulate_ops *ops,
 				 u16 port, u16 len)
 {
+	if (ctxt->perm_ok)
+		return true;
+
 	if (emulator_bad_iopl(ctxt, ops))
 		if (!emulator_io_port_access_allowed(ctxt, ops, port, len))
 			return false;
+
+	ctxt->perm_ok = true;
+
 	return true;
 }
 
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 7e5f075..de54582 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -3997,6 +3997,7 @@ int emulate_instruction(struct kvm_vcpu *vcpu,
 		memcpy(c->regs, vcpu->arch.regs, sizeof c->regs);
 		vcpu->arch.emulate_ctxt.interruptibility = 0;
 		vcpu->arch.emulate_ctxt.exception = -1;
+		vcpu->arch.emulate_ctxt.perm_ok = false;
 
 		r = x86_decode_insn(&vcpu->arch.emulate_ctxt, &emulate_ops);
 		trace_kvm_emulate_insn_start(vcpu);
-- 
1.7.1


  parent reply	other threads:[~2010-07-29 12:11 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-29 12:11 [PATCH 0/2] Speedup ins instruction emulation a little Gleb Natapov
2010-07-29 12:11 ` [PATCH 1/2] KVM: x86 emulator: don't update vcpu state if instruction is restarted Gleb Natapov
2010-07-31 17:25   ` Avi Kivity
2010-08-01  8:28     ` Gleb Natapov
2010-08-01  8:54       ` Avi Kivity
2010-08-01  9:01         ` Gleb Natapov
2010-08-01  9:14           ` Avi Kivity
2010-08-01  9:24             ` Gleb Natapov
2010-08-01 10:00               ` Avi Kivity
2010-08-01 10:53                 ` Gleb Natapov
2010-08-01 12:17                   ` Avi Kivity
2010-08-01 12:23                     ` Gleb Natapov
2010-08-01 12:35                       ` Avi Kivity
2010-08-01 13:27                         ` Gleb Natapov
2010-08-02  5:04                           ` Avi Kivity
2010-08-02  7:58                             ` Gleb Natapov
2010-08-02  8:03                               ` Avi Kivity
2010-08-02  8:17                                 ` Gleb Natapov
2010-08-02  8:24                                   ` Avi Kivity
2010-08-02  8:34                                     ` Gleb Natapov
2010-08-02  8:54                                       ` Avi Kivity
2010-08-02  9:05                                         ` Gleb Natapov
2010-08-02  9:08                                           ` Avi Kivity
2010-07-29 12:11 ` Gleb Natapov [this message]
2010-07-31  1:59   ` [PATCH 2/2] KVM: x86 emulator: check io permissions only once for string pio Marcelo Tosatti
2010-07-29 12:19 ` [PATCH 0/2] Speedup ins instruction emulation a little Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1280405513-579-3-git-send-email-gleb@redhat.com \
    --to=gleb@redhat.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox