From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: [PATCH 00/22] Direct decode in emulator Date: Thu, 29 Jul 2010 15:11:33 +0300 Message-ID: <1280405515-22459-1-git-send-email-avi@redhat.com> To: Marcelo Tosatti , kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:7335 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757217Ab0G2ML5 (ORCPT ); Thu, 29 Jul 2010 08:11:57 -0400 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o6TCBuwn017655 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 29 Jul 2010 08:11:56 -0400 Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com [10.35.255.11]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o6TCBtqW006135 for ; Thu, 29 Jul 2010 08:11:56 -0400 Sender: kvm-owner@vger.kernel.org List-ID: Currently the emulator decoder is indirect in two ways: groups are looked up in a separate table based on group number; and opcode execution is looked up in a big switch (actually two) after the opcode flags lookup. This patchset converts groups to direct decode and begins the work for opcode decode. The motivations are: - reduce errors from discrepancies between the two tables (like we had for IRET) - make the code easier to read, removing many switch () statements - eventually remove the #UD mini-decoder in x86.c by adding subgroup support to the emulator Avi Kivity (22): KVM: x86 emulator: drop parentheses in repreat macros KVM: x86 emulator: introduce 'struct opcode' KVM: x86 emulator: Add wrappers for easily defining opcodes KVM: x86 emulator: move group tables to top KVM: x86 emulator: reserve group code 0 KVM: x86 emulator: allow specifying group directly in opcode KVM: x86 emulator: convert group 1 to new style KVM: x86 emulator: convert group 1A to new style KVM: x86 emulator: convert group 3 to new style KVM: x86 emulator: convert group 4 to new style KVM: x86 emulator: convert group 5 to new style KVM: x86 emulator: convert group 7 to new style KVM: x86 emulator: convert group 8 to new style KVM: x86 emulator: convert group 9 to new style KVM: x86 emulator: drop support for old-style groups KVM: x86 emulator: move ByteOp and Dst back to bits 0:3 KVM: x86 emulator: store x86_emulate_ops in emulation context KVM: x86 emulator: allow storing emulator execution function in decode tables KVM: x86 emulator: move x86_decode_insn() downwards KVM: x86 emulator: move decode tables downwards KVM: x86 emulator: allow repeat macro arguments to contain commas KVM: x86 emulator: convert some push instructions to direct decode arch/x86/include/asm/kvm_emulate.h | 10 +- arch/x86/kvm/emulate.c | 1253 +++++++++++++++++++----------------- arch/x86/kvm/x86.c | 7 +- 3 files changed, 661 insertions(+), 609 deletions(-)