public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>
Subject: [PATCH 12/15] KVM: x86 emulator: add NoAccess flag for memory instructions that skip access
Date: Sun,  1 Aug 2010 17:23:30 +0300	[thread overview]
Message-ID: <1280672613-14026-13-git-send-email-avi@redhat.com> (raw)
In-Reply-To: <1280672613-14026-1-git-send-email-avi@redhat.com>

Use for INVLPG, which accesses the tlb, not memory.

Signed-off-by: Avi Kivity <avi@redhat.com>
---
 arch/x86/kvm/emulate.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
index 5bc62f2..29312a0 100644
--- a/arch/x86/kvm/emulate.c
+++ b/arch/x86/kvm/emulate.c
@@ -83,6 +83,7 @@
 #define Group       (1<<14)     /* Bits 3:5 of modrm byte extend opcode */
 #define GroupDual   (1<<15)     /* Alternate decoding of mod == 3 */
 /* Misc flags */
+#define NoAccess    (1<<23) /* Don't access memory (lea/invlpg/verr etc) */
 #define Force64     (1<<24) /* Force operand size to 64 bits in 64-bit mode */
 #define Undefined   (1<<25) /* No Such Instruction */
 #define Lock        (1<<26) /* lock prefix is allowed for the instruction */
@@ -2062,7 +2063,8 @@ static struct opcode group5[] = {
 static struct group_dual group7 = { {
 	N, N, D(ModRM | SrcMem | Priv), D(ModRM | SrcMem | Priv),
 	D(SrcNone | ModRM | DstMem | Mov), N,
-	D(SrcMem16 | ModRM | Mov | Priv), D(SrcMem | ModRM | ByteOp | Priv),
+	D(SrcMem16 | ModRM | Mov | Priv),
+	D(SrcMem | ModRM | ByteOp | Priv | NoAccess),
 }, {
 	D(SrcNone | ModRM | Priv), N, N, D(SrcNone | ModRM | Priv),
 	D(SrcNone | ModRM | DstMem | Mov), N,
@@ -2444,7 +2446,7 @@ done_prefixes:
 		c->src.bytes = (c->d & ByteOp) ? 1 :
 							   c->op_bytes;
 		/* Don't fetch the address for invlpg: it could be unmapped. */
-		if (c->twobyte && c->b == 0x01 && c->modrm_reg == 7)
+		if (c->d & NoAccess)
 			break;
 	srcmem_common:
 		/*
-- 
1.7.1


  parent reply	other threads:[~2010-08-01 14:23 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-01 14:23 [PATCH 00/15] More emulator cleanups Avi Kivity
2010-08-01 14:23 ` [PATCH 01/15] KVM: x86 emulator: push segment override out of decode_modrm() Avi Kivity
2010-08-01 14:23 ` [PATCH 02/15] KVM: x86 emulator: use correct type for memory address in operands Avi Kivity
2010-08-01 14:23 ` [PATCH 03/15] KVM: x86 emulator: simplify xchg decode tables Avi Kivity
2010-08-01 14:23 ` [PATCH 04/15] KVM: x86 emulator: use SrcAcc to simplify xchg decoding Avi Kivity
2010-08-01 14:23 ` [PATCH 05/15] KVM: x86 emulator: put register operand fetch into a function Avi Kivity
2010-08-01 14:23 ` [PATCH 06/15] KVM: x86 emulator: drop use_modrm_ea Avi Kivity
2010-08-01 14:23 ` [PATCH 07/15] KVM: x86 emulator: simplify REX.W check Avi Kivity
2010-08-01 14:23 ` [PATCH 08/15] KVM: x86 emulator: introduce Force64 for forcing operand size to 64 bits Avi Kivity
2010-08-01 14:23 ` [PATCH 09/15] KVM: x86 emulator: mark mov cr and mov dr as 64-bit instructions in long mode Avi Kivity
2010-08-02  7:37   ` Avi Kivity
2010-08-01 14:23 ` [PATCH 10/15] KVM: x86 emulator: use struct operand for mov reg,cr and mov cr,reg for reg op Avi Kivity
2010-08-01 14:23 ` [PATCH 11/15] KVM: x86 emulator: use struct operand for mov reg,dr and mov dr,reg " Avi Kivity
2010-08-01 14:23 ` Avi Kivity [this message]
2010-08-01 14:23 ` [PATCH 13/15] KVM: x86 emulator: switch LEA to use SrcMem decoding Avi Kivity
2010-08-01 14:23 ` [PATCH 14/15] KVM: x86 emulator: change invlpg emulation to use src.mem.addr Avi Kivity
2010-08-01 14:23 ` [PATCH 15/15] KVM: x86 emulator: Decode memory operands directly into a 'struct operand' Avi Kivity
2010-08-02  7:28   ` Paolo Bonzini
2010-08-02  7:36     ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1280672613-14026-13-git-send-email-avi@redhat.com \
    --to=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox