From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Meneghel Rodrigues Subject: Re: [PATCH] test: add svm tests Date: Mon, 02 Aug 2010 14:31:21 -0300 Message-ID: <1280770281.2552.182.camel@freedom> References: <1280760966-16717-1-git-send-email-avi@redhat.com> <4C56F90D.9090206@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:61420 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752000Ab0HBRb1 (ORCPT ); Mon, 2 Aug 2010 13:31:27 -0400 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o72HVRN1001892 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 2 Aug 2010 13:31:27 -0400 In-Reply-To: <4C56F90D.9090206@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, 2010-08-02 at 19:57 +0300, Avi Kivity wrote: > On 08/02/2010 05:56 PM, Avi Kivity wrote: > > Test behaviour both with svm enabled and with svm disabled. > > > > Signed-off-by: Avi Kivity > > --- > > kvm/test/x86/unittests.cfg | 10 ++++++++++ > > 1 files changed, 10 insertions(+), 0 deletions(-) > > > > diff --git a/kvm/test/x86/unittests.cfg b/kvm/test/x86/unittests.cfg > > index f39c5bd..7796e41 100644 > > --- a/kvm/test/x86/unittests.cfg > > +++ b/kvm/test/x86/unittests.cfg > > @@ -53,3 +53,13 @@ file = xsave.flat > > > > [rmap_chain] > > file = rmap_chain.flat > > + > > +[svm] > > +file = svm.flat > > +smp = 2 > > +extra_params = -enable-nesting -cpu qemu64,+svm > > + > > +[svm-disabled] > > +file = svm.flat > > +smp = 2 > > +extra_params = -cpu qemu64,-svm > > This doesn't appear to work. The test is run, but smp and extra_params > are ignored: > > 08/02 19:51:05 DEBUG| kvm_vm:0637| Running qemu command: > /root/autotest/client/tests/kvm/qemu -name 'vm1' -monitor > unix:'/tmp/monitor-humanmonitor1-20100802-194922-fika',server,nowait > -serial unix:'/tmp/serial-20100802-194922-fika',server,nowait -m 512 > -kernel '/root/autotest/client/tests/kvm/unittests/svm.flat' -vnc :0 > -chardev file,id=testlog,path=/tmp/testlog-20100802-194922-fika -device > testdev,chardev=testlog -S Ok, my fault, I have fixed it and just sent a patch upstream. Will commit soon and rebase the internal test tree afterwards. Sorry and thanks for pointing this out! Lucas