From: Glauber Costa <glommer@redhat.com>
To: kvm@vger.kernel.org
Cc: avi@redhat.com, zamsden@redhat.com, mtosatti@redhat.com, riel@redhat.com
Subject: [RFC 6/7] touch softlockup watchdog
Date: Wed, 25 Aug 2010 17:43:16 -0400 [thread overview]
Message-ID: <1282772597-4183-7-git-send-email-glommer@redhat.com> (raw)
In-Reply-To: <1282772597-4183-6-git-send-email-glommer@redhat.com>
With a reliable steal time mechanism, we can tell if we're
out of the cpu for very long, differentiating from the case
that we simply got a real softlockup.
In the case we were out of cpu, the watchdog is fed, making
bogus softlockups disappear.
Signed-off-by: Glauber Costa <glommer@redhat.com>
---
arch/x86/kernel/kvmclock.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c
index a1f4852..1c496c8 100644
--- a/arch/x86/kernel/kvmclock.c
+++ b/arch/x86/kernel/kvmclock.c
@@ -104,6 +104,9 @@ cputime_t kvm_get_steal_time(void)
delta = this_steal_info - *last_steal_info;
+ if (delta > 1000UL)
+ touch_softlockup_watchdog();
+
*last_steal_info = this_steal_info;
put_cpu_var(steal_info);
--
1.6.2.2
next prev parent reply other threads:[~2010-08-25 21:59 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 21:43 [RFC 0/7] KVM steal time implementation Glauber Costa
2010-08-25 21:43 ` [RFC 1/7] Implement getnsboottime kernel API Glauber Costa
2010-08-25 21:43 ` [RFC 2/7] change headers preparing for steal time Glauber Costa
2010-08-25 21:43 ` [RFC 3/7] measure time out of guest Glauber Costa
2010-08-25 21:43 ` [RFC 4/7] change kernel accounting to include steal time Glauber Costa
2010-08-25 21:43 ` [RFC 5/7] kvm steal time implementation Glauber Costa
2010-08-25 21:43 ` Glauber Costa [this message]
2010-08-25 21:43 ` [RFC 7/7] tell guest about steal time feature Glauber Costa
2010-08-26 22:13 ` [RFC 5/7] kvm steal time implementation Rik van Riel
2010-08-26 22:35 ` Glauber Costa
2010-08-26 17:23 ` [RFC 4/7] change kernel accounting to include steal time Marcelo Tosatti
2010-08-26 20:28 ` Glauber Costa
2010-08-26 20:47 ` Marcelo Tosatti
2010-08-26 21:05 ` Rik van Riel
2010-08-26 21:13 ` Glauber Costa
2010-08-26 21:14 ` Anthony Liguori
2010-08-26 21:40 ` Glauber Costa
2010-08-26 23:12 ` Marcelo Tosatti
2010-08-27 0:33 ` Glauber Costa
2010-08-27 15:25 ` Marcelo Tosatti
2010-08-26 21:19 ` Rik van Riel
2010-08-26 21:39 ` Glauber Costa
2010-08-29 9:59 ` Avi Kivity
2010-08-29 15:13 ` Rik van Riel
2010-08-29 15:25 ` Avi Kivity
2010-08-29 15:42 ` Rik van Riel
2010-08-29 15:47 ` Avi Kivity
2010-08-30 12:42 ` Glauber Costa
2010-08-30 13:15 ` Avi Kivity
2010-08-26 20:54 ` [RFC 3/7] measure time out of guest Zachary Amsden
2010-08-26 21:14 ` Glauber Costa
2010-08-29 9:53 ` Avi Kivity
2010-08-26 20:44 ` [RFC 2/7] change headers preparing for steal time Zachary Amsden
2010-08-26 21:04 ` Rik van Riel
2010-08-26 21:17 ` Glauber Costa
2010-08-26 22:11 ` Rik van Riel
2010-08-29 9:51 ` Avi Kivity
2010-08-30 12:44 ` Glauber Costa
2010-08-30 13:10 ` Avi Kivity
2010-08-26 19:46 ` [RFC 1/7] Implement getnsboottime kernel API Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282772597-4183-7-git-send-email-glommer@redhat.com \
--to=glommer@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=riel@redhat.com \
--cc=zamsden@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox