From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Rostedt Subject: Re: ftrace/perf_event leak Date: Wed, 01 Sep 2010 09:59:45 -0400 Message-ID: <1283349585.2356.1.camel@gandalf.stny.rr.com> References: <4C7E11E5.1040402@redhat.com> <1283331868.2059.808.camel@laptop> <4C7E1C36.6070400@redhat.com> <4C7E1F12.8030304@cn.fujitsu.com> <4C7E2D1D.3080603@redhat.com> <1283338977.2059.938.camel@laptop> <20100901121518.GA5378@nowhere> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: 7bit Cc: Peter Zijlstra , Avi Kivity , Li Zefan , Ingo Molnar , kvm-devel , Linux Kernel Mailing List To: Frederic Weisbecker Return-path: Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:35046 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754650Ab0IAN7s (ORCPT ); Wed, 1 Sep 2010 09:59:48 -0400 In-Reply-To: <20100901121518.GA5378@nowhere> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, 2010-09-01 at 14:15 +0200, Frederic Weisbecker wrote: > Thanks for fixing this. > > However, can we split this in two patches to ease the backport? > > The lack of a module_put() after perf_trace_init() failure is there for a while > (the backport needs to start in 2.6.32). > > But the lack of a module_put in the destroy path needs a .35 backport only. I don't think it really needs two patches. Just notify stable (and Greg KH in particular) about the backport requirements. Greg can handle it ;) -- Steve