public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Lucas Meneghel Rodrigues <lmr@redhat.com>
To: autotest@test.kernel.org
Cc: kvm@vger.kernel.org, mst@redhat.com
Subject: [PATCH 03/18] KVM test: Remove address_pools.cfg dependency
Date: Mon, 27 Sep 2010 18:43:49 -0400	[thread overview]
Message-ID: <1285627444-2732-4-git-send-email-lmr@redhat.com> (raw)
In-Reply-To: <1285627444-2732-1-git-send-email-lmr@redhat.com>

Since the previous patch introduces an automated management
mechanism for MAC addresses, let's simplify things a bit
by removing address_pools.cfg parsing from the control files,
as well as just removing address_pools.cfg.sample.

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
---
 client/tests/kvm/address_pools.cfg.sample |   65 -----------------------------
 client/tests/kvm/control                  |    8 ----
 client/tests/kvm/control.parallel         |    9 ----
 client/tests/kvm/get_started.py           |    4 +-
 4 files changed, 2 insertions(+), 84 deletions(-)
 delete mode 100644 client/tests/kvm/address_pools.cfg.sample

diff --git a/client/tests/kvm/address_pools.cfg.sample b/client/tests/kvm/address_pools.cfg.sample
deleted file mode 100644
index b5967ce..0000000
--- a/client/tests/kvm/address_pools.cfg.sample
+++ /dev/null
@@ -1,65 +0,0 @@
-# Copy this file to address_pools.cfg and edit it.
-#
-# This file specifies several MAC-IP ranges for each host in the network that
-# may run KVM tests.  A MAC address must not be used twice, so these ranges
-# must not overlap.  The VMs running on each host will only use MAC addresses
-# from the pool of that host.
-# If you wish to use a static MAC-IP mapping, where each MAC address range is
-# mapped to a known corresponding IP address range, specify the bases of the IP
-# address ranges in this file.
-# If you specify a MAC address range without a corresponding IP address range,
-# the IP addresses for that range will be determined at runtime by listening
-# to DHCP traffic using tcpdump.
-# If you wish to determine IP addresses using tcpdump in any case, regardless
-# of any # IP addresses specified in this file, uncomment the following line:
-#always_use_tcpdump = yes
-# You may also specify this parameter for specific hosts by adding it in the
-# appropriate sections below.
-
-variants:
-    # Rename host1 to an actual (short) hostname in the network that will be running the Autotest client
-    - @host1:
-        # Add/remove ranges here
-        address_ranges = r1 r2
-
-        # Modify the following parameters to reflect the DHCP server's configuration
-        address_range_base_mac_r1 = 52:54:00:12:35:56
-        #address_range_base_ip_r1 = 10.0.2.20
-        address_range_size_r1 = 16
-
-        # Modify the following parameters to reflect the DHCP server's configuration
-        address_range_base_mac_r2 = 52:54:00:12:35:80
-        #address_range_base_ip_r2 = 10.0.2.40
-        address_range_size_r2 = 16
-
-    # Rename host2 to an actual (short) hostname in the network that will be running the Autotest client
-    - @host2:
-        # Add/remove ranges here
-        address_ranges = r1 r2
-
-        # Modify the following parameters to reflect the DHCP server's configuration
-        address_range_base_mac_r1 = 52:54:00:12:36:56
-        #address_range_base_ip_r1 = 10.0.3.20
-        address_range_size_r1 = 16
-
-        # Modify the following parameters to reflect the DHCP server's configuration
-        address_range_base_mac_r2 = 52:54:00:12:36:80
-        #address_range_base_ip_r2 = 10.0.3.40
-        address_range_size_r2 = 16
-
-    # Add additional hosts here...
-
-    # This will be used for hosts that do not appear on the list
-    - @default_host:
-        # Add/remove ranges here
-        address_ranges = r1 r2
-
-        # Modify the following parameters to reflect the DHCP server's configuration
-        address_range_base_mac_r1 = 52:54:00:12:34:56
-        #address_range_base_ip_r1 = 10.0.1.20
-        address_range_size_r1 = 16
-
-        # Modify the following parameters to reflect the DHCP server's configuration
-        address_range_base_mac_r2 = 52:54:00:12:34:80
-        #address_range_base_ip_r2 = 10.0.1.40
-        address_range_size_r2 = 16
diff --git a/client/tests/kvm/control b/client/tests/kvm/control
index a69eacf..63bbe5d 100644
--- a/client/tests/kvm/control
+++ b/client/tests/kvm/control
@@ -55,14 +55,6 @@ tests_cfg = kvm_config.config()
 tests_cfg_path = os.path.join(kvm_test_dir, "tests.cfg")
 tests_cfg.fork_and_parse(tests_cfg_path, str)
 
-pools_cfg_path = os.path.join(kvm_test_dir, "address_pools.cfg")
-tests_cfg.parse_file(pools_cfg_path)
-hostname = os.uname()[1].split(".")[0]
-if tests_cfg.count("^" + hostname):
-    tests_cfg.parse_string("only ^%s" % hostname)
-else:
-    tests_cfg.parse_string("only ^default_host")
-
 # Run the tests
 kvm_utils.run_tests(tests_cfg.get_generator(), job)
 
diff --git a/client/tests/kvm/control.parallel b/client/tests/kvm/control.parallel
index 07bc6e5..ac84638 100644
--- a/client/tests/kvm/control.parallel
+++ b/client/tests/kvm/control.parallel
@@ -171,15 +171,6 @@ cfg = kvm_config.config()
 filename = os.path.join(pwd, "tests.cfg")
 cfg.fork_and_parse(filename, str)
 
-filename = os.path.join(pwd, "address_pools.cfg")
-if os.path.exists(filename):
-    cfg.parse_file(filename)
-    hostname = os.uname()[1].split(".")[0]
-    if cfg.count("^" + hostname):
-        cfg.parse_string("only ^%s" % hostname)
-    else:
-        cfg.parse_string("only ^default_host")
-
 tests = cfg.get_list()
 
 
diff --git a/client/tests/kvm/get_started.py b/client/tests/kvm/get_started.py
index 00b5f6b..6fa6b5f 100755
--- a/client/tests/kvm/get_started.py
+++ b/client/tests/kvm/get_started.py
@@ -68,8 +68,8 @@ if __name__ == "__main__":
                  "config samples to actual config files)")
     kvm_test_dir = os.path.dirname(sys.modules[__name__].__file__)
     kvm_test_dir = os.path.abspath(kvm_test_dir)
-    config_file_list = ["address_pools.cfg", "build.cfg", "cdkeys.cfg",
-                        "tests_base.cfg", "tests.cfg", "unittests.cfg"]
+    config_file_list = ["build.cfg", "cdkeys.cfg", "tests_base.cfg",
+                        "tests.cfg", "unittests.cfg"]
     for config_file in config_file_list:
         src_file = os.path.join(kvm_test_dir, "%s.sample" % config_file)
         dst_file = os.path.join(kvm_test_dir, config_file)
-- 
1.7.1

  parent reply	other threads:[~2010-09-27 22:43 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-27 22:43 [PATCH 00/18] Network Patchset v4 Lucas Meneghel Rodrigues
2010-09-27 22:43 ` [PATCH 01/18] KVM test: Add a new macaddress pool algorithm Lucas Meneghel Rodrigues
2010-09-27 22:43 ` [PATCH 02/18] KVM test: Make physical_resources_check to work with MAC management Lucas Meneghel Rodrigues
2010-09-27 22:43 ` Lucas Meneghel Rodrigues [this message]
2010-09-27 22:43 ` [PATCH 04/18] KVM test: Add a get_ifname function Lucas Meneghel Rodrigues
2010-09-27 22:43 ` [PATCH 05/18] KVM Test: Add nw related functions ping and get_linux_ifname Lucas Meneghel Rodrigues
2010-09-27 22:43 ` [PATCH 06/18] KVM test: Add a new subtest ping Lucas Meneghel Rodrigues
2010-09-27 22:43 ` [PATCH 07/18] KVM test: Add a subtest jumbo Lucas Meneghel Rodrigues
2010-09-29  6:42   ` pradeep
2010-09-29 11:07     ` Lucas Meneghel Rodrigues
2010-09-29 11:33       ` pradeep
2010-09-29 20:21         ` Lucas Meneghel Rodrigues
2010-09-30  7:05           ` pradeep
2010-09-27 22:43 ` [PATCH 08/18] KVM test: Add basic file transfer test Lucas Meneghel Rodrigues
2010-09-28 13:24   ` Michael S. Tsirkin
2010-09-29 11:45     ` pradeep
2010-09-29 12:33       ` Lucas Meneghel Rodrigues
2010-09-29 14:08     ` Lucas Meneghel Rodrigues
2010-09-29 17:43     ` Lucas Meneghel Rodrigues
2010-09-27 22:43 ` [PATCH 09/18] KVM test: Add a subtest of load/unload nic driver Lucas Meneghel Rodrigues
2010-10-06  5:49   ` Amos Kong
2010-09-27 22:43 ` [PATCH 10/18] KVM test: Add a subtest of nic promisc Lucas Meneghel Rodrigues
2010-09-27 22:43 ` [PATCH 11/18] KVM test: Add a subtest of multicast Lucas Meneghel Rodrigues
2010-09-30  9:30   ` pradeep
2010-10-05 12:21   ` Amos Kong
2010-10-05 12:44     ` Lucas Meneghel Rodrigues
2010-09-27 22:43 ` [PATCH 12/18] KVM test: Add a subtest of pxe Lucas Meneghel Rodrigues
2010-09-27 22:43 ` [PATCH 13/18] KVM test: Add a subtest of changing MAC address Lucas Meneghel Rodrigues
2010-09-30  8:21   ` pradeep
2010-09-27 22:44 ` [PATCH 14/18] KVM test: Add a netperf subtest Lucas Meneghel Rodrigues
2010-10-05  9:00   ` pradeep
2010-10-05 12:59     ` Amos Kong
2010-10-06 10:48       ` pradeep
2010-09-27 22:44 ` [PATCH 15/18] KVM test: kvm_utils - Add support of check if remote port free Lucas Meneghel Rodrigues
2010-09-27 22:44 ` [PATCH 16/18] KVM test: Improve vlan subtest Lucas Meneghel Rodrigues
2010-09-30  6:59   ` pradeep
2010-10-05 12:56     ` Amos Kong
2010-09-27 22:44 ` [PATCH 17/18] KVM test: vlan subtest - Replace extra_params '-snapshot' with image_snapshot Lucas Meneghel Rodrigues
2010-09-27 22:44 ` [PATCH 18/18] KVM test: Add subtest of testing offload by ethtool Lucas Meneghel Rodrigues
2010-10-06  8:56   ` pradeep
2010-10-06  9:59     ` [Autotest] " pradeep
2010-10-06 15:55     ` Ryan Harper
2010-10-06 16:57       ` Lucas Meneghel Rodrigues
2010-10-07  2:09 ` [PATCH 00/18] Network Patchset v4 Lucas Meneghel Rodrigues
2010-10-07 13:45   ` [Autotest] " pradeep
2010-10-07 13:54     ` Lucas Meneghel Rodrigues
2010-10-07 14:37       ` pradeep
2010-10-07 15:00         ` [Autotest] " Michael S. Tsirkin
2010-10-08 12:27           ` Lucas Meneghel Rodrigues
  -- strict thread matches above, loose matches on Subject: below --
2010-09-14 22:25 [PATCH 00/18] KVM autotest network patchset v3 Lucas Meneghel Rodrigues
2010-09-14 22:25 ` [PATCH 03/18] KVM test: Remove address_pools.cfg dependency Lucas Meneghel Rodrigues

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1285627444-2732-4-git-send-email-lmr@redhat.com \
    --to=lmr@redhat.com \
    --cc=autotest@test.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox