Re: [KVM_AUTOTEST][RFC 0/3]: QMP basic test-suite

[Lucas Meneghel Rodrigues <lmr@redhat.com>]

On Thu, 2010-10-07 at 16:52 -0300, Luiz Capitulino wrote:
> This series is an _initial_ work on having a full QMP test-suite in
> kvm-autotest. I think it's very near of being in a mergeable state, but I
> figured it would be a good idea to get some feedback before submitting the
> final version.
> 
> You'll find all important details in the patches, being the last the most
> important one.
> 
> Please, note that there are a number of TODO items to be addressed and I
> need help to solve the following issues:
> 
>     1. A number of QMP commands are executed before the QMP suite is run,
>        which means that some problems can be caught by non-test code (ie.
>        real usage).

We can test it in a dedicated job, that does qemu specific testing (ie,
non-vm related work, such as qmp, qemu-block, qemu-unittests and such),
or even have a fully dedicated job to qmp.

>        Ideally, the QMP suite should be run before any command is executed,
>        so that we avoid catching QMP bugs in other test suites and/or in
>        kvm-autotest non-test code.
> 
>     2. The qmp_capabilities command is run by the QMPMonitor class
>        constructor. This makes it impossible for me to test it in the QMP
>        suite.
> 
>        I have tried destroying and recreating the QMPMonitor object from
>        my test-suite, but that didn't seem to work very well.

We can add an additional parameter to test parameters that indicates
whether the monitors are going to be tested. Today we have this in
tests_base.cfg.sample:

monitors = humanmonitor1

# Choose the main VM and monitor
main_vm = vm1
main_monitor = humanmonitor1
...
# Monitor params
monitor_type = human

We can add an additional parameter (maybe monitor_mode_[monitor_name])
to indicate the monitor is under test:

monitor_mode_humanmonitor1 = test
or
monitor_mode_humanmonitor1 = normal

We are indicating whether a given monitor is under test or not with this
parameter (defaults allways to normal). If mode is 'test', we handle
monitor class initialization, and potentially, other methods
differently. What do you think?

> I have other, more general comments, about kvm-autotest, but I'll send them
> in a different thread.

All right Luiz, this is all excellent, thanks!

> Thanks.
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html