From: Lucas Meneghel Rodrigues <lmr@redhat.com>
To: autotest@test.kernel.org
Cc: kvm@vger.kernel.org
Subject: [PATCH 2/2] KVM test: Remove image_boot=yes from virtio_blk variant
Date: Thu, 14 Oct 2010 01:24:12 -0300 [thread overview]
Message-ID: <1287030252-3291-2-git-send-email-lmr@redhat.com> (raw)
In-Reply-To: <1287030252-3291-1-git-send-email-lmr@redhat.com>
Recent qemu can handle virtio without boot without boot=on,
and qemu.git will simply state the option as invalid. So
remove it from the default config on tests_base.cfg, just
leave it there commented in case someone is testing older
versions.
Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
---
client/tests/kvm/tests_base.cfg.sample | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/client/tests/kvm/tests_base.cfg.sample b/client/tests/kvm/tests_base.cfg.sample
index 87fd51d..f8c70fe 100644
--- a/client/tests/kvm/tests_base.cfg.sample
+++ b/client/tests/kvm/tests_base.cfg.sample
@@ -1914,7 +1914,9 @@ variants:
drive_format=scsi
- virtio_blk:
drive_format=virtio
- image_boot=yes
+ # Some older qemu might need image_boot=yes for virtio images to work.
+ # Please uncomment the below if that is the case.
+ #image_boot=yes
virtio_net|virtio_blk|e1000|balloon_check:
--
1.7.2.3
next prev parent reply other threads:[~2010-10-14 4:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-14 4:24 [PATCH 1/2] KVM test: Make cache=none the default on KVM autotest runs Lucas Meneghel Rodrigues
2010-10-14 4:24 ` Lucas Meneghel Rodrigues [this message]
2010-10-14 6:37 ` [PATCH 2/2] KVM test: Remove image_boot=yes from virtio_blk variant pradeep
2010-10-14 9:26 ` [AUTOTEST] [PATCH 1/2] KVM : ping6 test pradeep
2010-10-14 10:05 ` Amos Kong
2010-10-14 10:45 ` [Autotest] " pradeep
2010-10-14 9:29 ` pradeep
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287030252-3291-2-git-send-email-lmr@redhat.com \
--to=lmr@redhat.com \
--cc=autotest@test.kernel.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox